Upstream service wrkr "skipWaiting" tests to WPT

Upstream service wrkr "skipWaiting" tests to WPT

**skip-waiting-installed**

This test exists in both the Web Platform Tests project and in the
Chromium project, but the two versions differ slightly. Update the Web
Platform Tests version with improvements available in the Chromium
version:

- Remove unnecessary `<script>` include
- Discourage worker termination by invoking `event.waitUntil`
- Refactor promise management to avoid timing out in response to
  assertion failures
- Introduce a "use strict" directive

The Chromium version contains an additional assertion that is faulty.
Extend the Web Platform Tests version with a corrected form of this
assertion. Persist the Chromium version in its current state in order to
preserve test coverage, but annotate that version with references to a
new Chromium issue which tracks the resolution of the underlying bug.

**skip-waiting-using-registration**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Refactor promise management to avoid timing out in response to
  assertion failures
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

**skip-waiting-without-client**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Remove an unnecessary `<script>`
include from the Web Platform Tests version. Remove the Chromium version
of the test.

**skip-waiting-without-using-registration**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

**skip-waiting**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

---

Remove the `skip-waiting-worker.js` "resource" file from the Chromium
project as it is no longer referenced by any tests.

BUG=688116, 725616
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2900183002
Cr-Commit-Position: refs/heads/master@{#475361}
Committed: https://chromium.googlesource.com/chromium/src/+/a03921af62dfc391b10999380a25e2baf2bf22bc

[mike3, 2017-05-23 20:59:18]

Hi Matt,

Would you mind reviewing this patch for me? Here's a diff of the files as they
exist in `master` today (i.e. prior to application of this patch):

https://gist.github.com/jugglinmike/00d873922e170016c85508fccbb42607

[falken, 2017-05-24 01:41:08]

On 2017/05/23 20:59:18, mike3 wrote:
> Hi Matt,
> 
> Would you mind reviewing this patch for me? Here's a diff of the files as they
> exist in `master` today (i.e. prior to application of this patch):
> 
> https://gist.github.com/jugglinmike/00d873922e170016c85508fccbb42607

Hey Mike, thanks for continuing your great work. Just want to give you a heads
up that I'm a bit busy due to the M60 branch point this week and some other time
sensitive work. So it might take me longer than usual to get back on your most
recent patches. Sorry for this. I want to make sure I give the patches the
careful reviews they deserve.

[mike3, 2017-05-24 14:19:43]

On 2017/05/24 01:41:08, falken wrote:
> On 2017/05/23 20:59:18, mike3 wrote:
> > Hi Matt,
> > 
> > Would you mind reviewing this patch for me? Here's a diff of the files as
they
> > exist in `master` today (i.e. prior to application of this patch):
> > 
> > https://gist.github.com/jugglinmike/00d873922e170016c85508fccbb42607
> 
> Hey Mike, thanks for continuing your great work. Just want to give you a heads
> up that I'm a bit busy due to the M60 branch point this week and some other
time
> sensitive work. So it might take me longer than usual to get back on your most
> recent patches. Sorry for this. I want to make sure I give the patches the
> careful reviews they deserve.

No problem at all, Matt. I plan to continue submitting patches, but please
don't take that as impatience on my part. They're all mostly independent, so I
don't mind if they queue up.

Thanks for the heads up!

[falken, 2017-05-29 03:54:17]

thanks, lgtm. Sorry for the delay.

https://codereview.chromium.org/2900183002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js
(right):

https://codereview.chromium.org/2900183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js:27:
'This assertion is invalid. See https://crbug.com/725616');
I'd be more explicit. The negative asserts in this test are a little confusing:

'This assertion passes in current Chromium (i.e., self.state is 'activating'),
but it should fail. See https://crbug.com/725616'

[mike3, 2017-05-29 15:11:49]

> thanks, lgtm. Sorry for the delay.

No problem at all. And thank you!

https://codereview.chromium.org/2900183002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js
(right):

https://codereview.chromium.org/2900183002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js:27:
'This assertion is invalid. See https://crbug.com/725616');
On 2017/05/29 03:54:17, falken wrote:
> I'd be more explicit. The negative asserts in this test are a little
confusing:
> 
> 'This assertion passes in current Chromium (i.e., self.state is 'activating'),
> but it should fail. See https://crbug.com/725616

Done.

[mike3, 2017-05-29 15:12:16]

The CQ bit was checked by mike@mikepennisi.com

[mike3, 2017-05-29 15:12:17]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2900183002/#ps10001
(title: "Improve assertion message")

[commit-bot: I haz the power, 2017-05-29 15:12:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 17:01:28]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1496070736989580,
"parent_rev": "ae70e708c0a58bf54e190956cb9a560bb5036974", "commit_rev":
"a03921af62dfc391b10999380a25e2baf2bf22bc"}

[commit-bot: I haz the power, 2017-05-29 17:01:38]

Description was changed from

==========
Upstream service wrkr "skipWaiting" tests to WPT

**skip-waiting-installed**

This test exists in both the Web Platform Tests project and in the
Chromium project, but the two versions differ slightly. Update the Web
Platform Tests version with improvements available in the Chromium
version:

- Remove unnecessary `<script>` include
- Discourage worker termination by invoking `event.waitUntil`
- Refactor promise management to avoid timing out in response to
  assertion failures
- Introduce a "use strict" directive

The Chromium version contains an additional assertion that is faulty.
Extend the Web Platform Tests version with a corrected form of this
assertion. Persist the Chromium version in its current state in order to
preserve test coverage, but annotate that version with references to a
new Chromium issue which tracks the resolution of the underlying bug.

**skip-waiting-using-registration**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Refactor promise management to avoid timing out in response to
  assertion failures
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

**skip-waiting-without-client**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Remove an unnecessary `<script>`
include from the Web Platform Tests version. Remove the Chromium version
of the test.

**skip-waiting-without-using-registration**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

**skip-waiting**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

---

Remove the `skip-waiting-worker.js` "resource" file from the Chromium
project as it is no longer referenced by any tests.

BUG=688116, 725616
R=falken@chromium.org
==========

to

==========
Upstream service wrkr "skipWaiting" tests to WPT

**skip-waiting-installed**

This test exists in both the Web Platform Tests project and in the
Chromium project, but the two versions differ slightly. Update the Web
Platform Tests version with improvements available in the Chromium
version:

- Remove unnecessary `<script>` include
- Discourage worker termination by invoking `event.waitUntil`
- Refactor promise management to avoid timing out in response to
  assertion failures
- Introduce a "use strict" directive

The Chromium version contains an additional assertion that is faulty.
Extend the Web Platform Tests version with a corrected form of this
assertion. Persist the Chromium version in its current state in order to
preserve test coverage, but annotate that version with references to a
new Chromium issue which tracks the resolution of the underlying bug.

**skip-waiting-using-registration**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Refactor promise management to avoid timing out in response to
  assertion failures
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

**skip-waiting-without-client**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Remove an unnecessary `<script>`
include from the Web Platform Tests version. Remove the Chromium version
of the test.

**skip-waiting-without-using-registration**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

**skip-waiting**

This test exists in equivalent forms in both the Web Platform Tests
project and in the Chromium project. Update the Web Platform Tests
version:

- Remove unnecessary `<script>` include
- Increase prevision of test "cleanup" logic
- Introduce a "use strict" directive

Remove the Chromium version of the test.

---

Remove the `skip-waiting-worker.js` "resource" file from the Chromium
project as it is no longer referenced by any tests.

BUG=688116, 725616
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2900183002
Cr-Commit-Position: refs/heads/master@{#475361}
Committed:
https://chromium.googlesource.com/chromium/src/+/a03921af62dfc391b10999380a25...
==========

[commit-bot: I haz the power, 2017-05-29 17:01:39]

Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/a03921af62dfc391b10999380a25...