third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js - Issue 2900183002: Upstream service wrkr "skipWaiting" tests to WPT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js

Issue 2900183002: Upstream service wrkr "skipWaiting" tests to WPT (Closed)

Patch Set: Improve assertion message Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.skip-waiting-installed.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js

index 56b97a718034a4000a7a3b9519f452b97abbd999..3ae97a45b19e4b7bdb2b69578046faa8ebe922b7 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js

@@ -23,8 +23,9 @@ self.addEventListener('message', function(event) {

return;

}

if (self.state !== 'activating') {

- port.postMessage(

- 'FAIL: Promise should be resolved after worker activated');

+ port.postMessage('This assertion passes in current Chromium ' +

+ '(i.e., self.state is "activating"), ' +

+ 'but it should fail. See https://crbug.com/725616');

return;

}

port.postMessage('PASS');