third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https.html - Issue 2900183002: Upstream service wrkr "skipWaiting" tests to WPT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https.html

Issue 2900183002: Upstream service wrkr "skipWaiting" tests to WPT (Closed)

Patch Set: Improve assertion message Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/skip-waiting-installed-worker.js ('k') | third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https.html

diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https.html

index 795386f8cd6747c6b551195c9bfed9eda5c307ea..93dc06d103378ef908a7470a2287fe06ef3177d7 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https.html

+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/skip-waiting-installed.https.html

@@ -1,10 +1,10 @@

<!DOCTYPE html>

<title>Service Worker: Skip waiting installed worker</title>

-<script src="resources/testharness-helpers.js"></script>

+'use strict';

promise_test(function(t) {

var scope = 'resources/blank.html?skip-waiting-installed';

@@ -13,16 +13,17 @@ promise_test(function(t) {

var frame, frame_sw, service_worker, registration, onmessage, oncontrollerchanged;

var saw_message = new Promise(function(resolve) {

onmessage = function(e) {

- var message = e.data;

- assert_equals(

- message, 'PASS',

- 'skipWaiting promise should be resolved with undefined');

+ resolve(e.data);

+ };

+ })

+ .then(function(message) {

+ assert_equals(

+ message, 'PASS',

+ 'skipWaiting promise should be resolved with undefined');

- assert_equals(registration.active.scriptURL, normalizeURL(url2),

- "skipWaiting should make worker become active");

- resolve();

- };

- });

+ assert_equals(registration.active.scriptURL, normalizeURL(url2),

+ 'skipWaiting should make worker become active');

+ });

var saw_controllerchanged = new Promise(function(resolve) {

oncontrollerchanged = function() {

assert_equals(