Move DevTools out of ash and turn it to a component.

Move DevTools out of ash and turn it to a component. AshTestbase
dependency will be removed and replaced by ViewTestBase. Appropriate 
UIElement trees are also created to test DevTools.

BUG=701835
Review-Url: https://codereview.chromium.org/2899783002
Cr-Commit-Position: refs/heads/master@{#481047}
Committed: https://chromium.googlesource.com/chromium/src/+/3f39685180b85f09614e287f1150dabfc9fa9d05

[thanhph, 2017-05-22 16:32:26]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 16:32:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 16:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 16:37:12]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[thanhph, 2017-05-22 16:50:32]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 16:51:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 16:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 16:55:53]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph, 2017-05-22 17:03:35]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 17:04:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:08:51]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[thanhph, 2017-05-22 17:29:58]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 17:30:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:35:33]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph, 2017-05-22 17:37:07]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[thanhph, 2017-05-22 17:37:14]

Patchset #4 (id:60001) has been deleted

[thanhph, 2017-05-22 17:37:26]

Patchset #3 (id:40001) has been deleted

[thanhph, 2017-05-22 17:37:35]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-05-22 17:37:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 17:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 17:43:07]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph, 2017-05-23 14:32:30]

Description was changed from

==========
Move DevTools out of ash and turn it to a component.
WIP: Move DevTools out of ash and turn it to a component. This entails
removing AshTestbase dependency, use ViewTestBase and create
appropriate window/widget/view trees for DevTools unit test.

BUG=701835
==========

to

==========
Move DevTools out of ash and turn it to a component.
WIP: Move DevTools out of ash and turn it to a component. This entails
removing AshTestbase dependency, use ViewTestBase and create
appropriate window/widget/view trees for DevTools unit test.

BUG=701835
==========

[thanhph, 2017-05-28 03:23:58]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 03:24:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-28 03:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-28 03:27:34]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[thanhph, 2017-05-30 14:31:45]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 14:31:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 14:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:35:23]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[thanhph, 2017-05-30 16:53:37]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 16:54:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 16:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 16:58:16]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[thanhph, 2017-05-30 19:17:46]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 19:18:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:26:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[thanhph, 2017-05-30 19:30:05]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 19:30:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:37:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[thanhph, 2017-05-31 16:13:29]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 16:13:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-05-31 16:16:59]

Patchset #2 (id:80001) has been deleted

[thanhph, 2017-05-31 16:17:13]

Patchset #2 (id:100001) has been deleted

[thanhph, 2017-05-31 16:17:25]

Patchset #2 (id:120001) has been deleted

[thanhph, 2017-05-31 16:17:36]

Patchset #2 (id:140001) has been deleted

[thanhph, 2017-05-31 16:17:48]

Patchset #2 (id:160001) has been deleted

[thanhph, 2017-05-31 16:18:00]

Patchset #2 (id:180001) has been deleted

[thanhph, 2017-05-31 16:18:15]

Patchset #2 (id:200001) has been deleted

[thanhph, 2017-05-31 16:18:28]

Patchset #2 (id:220001) has been deleted

[thanhph, 2017-05-31 16:18:40]

Patchset #2 (id:240001) has been deleted

[thanhph, 2017-05-31 16:18:59]

Patchset #2 (id:260001) has been deleted

[thanhph, 2017-05-31 16:19:12]

Patchset #2 (id:280001) has been deleted

[thanhph, 2017-05-31 16:19:33]

Patchset #2 (id:300001) has been deleted

[commit-bot: I haz the power, 2017-05-31 16:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 16:22:47]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[thanhph, 2017-05-31 18:07:13]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:07:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-05-31 18:28:59]

The CQ bit was unchecked by thanhph@chromium.org

[thanhph, 2017-05-31 18:32:21]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:33:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-05-31 18:36:07]

The CQ bit was unchecked by thanhph@chromium.org

[thanhph, 2017-05-31 18:37:22]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:38:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-05-31 19:47:01]

Patchset #2 (id:320001) has been deleted

[thanhph, 2017-05-31 19:47:14]

Patchset #2 (id:340001) has been deleted

[thanhph, 2017-05-31 19:47:32]

Patchset #3 (id:380001) has been deleted

[thanhph, 2017-05-31 21:46:17]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 21:47:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-05-31 21:59:23]

The CQ bit was unchecked by thanhph@chromium.org

[thanhph, 2017-06-01 15:01:42]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 15:02:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 17:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 17:08:10]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[thanhph, 2017-06-01 21:01:37]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[thanhph, 2017-06-01 21:01:53]

The CQ bit was unchecked by thanhph@chromium.org

[thanhph, 2017-06-01 21:03:29]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 21:04:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 21:10:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 21:10:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph, 2017-06-01 21:50:48]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 21:52:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:11:41]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[thanhph, 2017-06-02 18:54:02]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 18:54:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-06-02 19:26:22]

The CQ bit was unchecked by thanhph@chromium.org

[thanhph, 2017-06-02 20:02:58]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 20:03:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-06-02 21:33:37]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 21:34:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 23:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 23:44:40]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[thanhph, 2017-06-04 21:58:14]

Patchset #3 (id:400001) has been deleted

[thanhph, 2017-06-04 21:58:27]

Patchset #3 (id:420001) has been deleted

[thanhph, 2017-06-04 21:58:38]

Patchset #3 (id:440001) has been deleted

[thanhph, 2017-06-04 21:58:48]

Patchset #3 (id:460001) has been deleted

[thanhph, 2017-06-04 21:59:04]

Patchset #3 (id:480001) has been deleted

[thanhph, 2017-06-04 21:59:16]

Patchset #3 (id:500001) has been deleted

[thanhph, 2017-06-04 21:59:28]

Patchset #3 (id:520001) has been deleted

[thanhph, 2017-06-04 21:59:39]

Patchset #3 (id:540001) has been deleted

[thanhph, 2017-06-04 22:00:01]

Patchset #3 (id:560001) has been deleted

[thanhph, 2017-06-04 22:00:25]

Patchset #3 (id:580001) has been deleted

[thanhph, 2017-06-04 22:10:37]

Patchset #4 (id:620001) has been deleted

[thanhph, 2017-06-04 22:17:31]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 22:17:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 23:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 23:37:01]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-04 23:55:47]

thanhph@chromium.org changed reviewers:
+ sadrul@chromium.org

[thanhph, 2017-06-04 23:55:49]

Hi Sadrul,

Please review my cl.

Thanks,
Thanh.

[thanhph, 2017-06-05 00:17:08]

Description was changed from

==========
Move DevTools out of ash and turn it to a component.
WIP: Move DevTools out of ash and turn it to a component. This entails
removing AshTestbase dependency, use ViewTestBase and create
appropriate window/widget/view trees for DevTools unit test.

BUG=701835
==========

to

==========
Move DevTools out of ash and turn it to a component. AshTestbase
dependency will be removed and replaced by ViewTestBase. Appropriate 
UIElement trees are also created to test DevTools.

BUG=701835
==========

[sadrul, 2017-06-05 21:37:42]

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
File components/ui_devtools/devtools/BUILD.gn (right):

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:3: source_set("devtools") {
Rename this directory: //components/ui_devtools/views

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:4: defines = [
"UI_DEVTOOLS_IMPLEMENTATION" ]
You should not need this.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:10: if (toolkit_views && use_aura) {
Don't need these checks here.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:39: defines = [
"UI_DEVTOOLS_IMPLEMENTATION" ]
You should not need this.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:45: if (toolkit_views && use_aura) {
Don't need these checks here.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
File components/ui_devtools/devtools/ui_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/ui_devtools_dom_agent.cc:347: params.parent =
root_windows()[0];
Do you need to add this back for some reason?

[thanhph, 2017-06-06 17:09:39]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 17:10:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 18:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 18:36:12]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[thanhph, 2017-06-06 19:32:54]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 19:33:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-06-06 20:45:53]

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
File components/ui_devtools/devtools/BUILD.gn (right):

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:3: source_set("devtools") {
On 2017/06/05 21:37:42, sadrul wrote:
> Rename this directory: //components/ui_devtools/views

Done.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:4: defines = [
"UI_DEVTOOLS_IMPLEMENTATION" ]
On 2017/06/05 21:37:42, sadrul wrote:
> You should not need this.

We need this to compile the code in window. You can see the error LNK4217 for
bots win_chromium_compile_dbg_ng and win_clang in patch set 6 and 7.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:10: if (toolkit_views && use_aura) {
On 2017/06/05 21:37:42, sadrul wrote:
> Don't need these checks here.

Done.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:39: defines = [
"UI_DEVTOOLS_IMPLEMENTATION" ]
On 2017/06/05 21:37:42, sadrul wrote:
> You should not need this.

We need this to compile the code in window.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/BUILD.gn:45: if (toolkit_views && use_aura) {
On 2017/06/05 21:37:42, sadrul wrote:
> Don't need these checks here.

Done.

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
File components/ui_devtools/devtools/ui_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2899783002/diff/660001/components/ui_devtools...
components/ui_devtools/devtools/ui_devtools_dom_agent.cc:347: params.parent =
root_windows()[0];
On 2017/06/05 21:37:42, sadrul wrote:
> Do you need to add this back for some reason?

Yes. This test UIDevToolsTest.WindowWidgetViewHighlight crashes at
native_widget_aura.cc(152)] Check failed: params.parent || params.context, so I
just added this back and positive workflow still works as expected for dual
screens.

[commit-bot: I haz the power, 2017-06-06 21:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 21:19:00]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-06-08 22:08:01]

Looks good. But I think we need to sort out the build issue on Windows.

https://codereview.chromium.org/2899783002/diff/720001/components/ui_devtools...
File components/ui_devtools/views/BUILD.gn (right):

https://codereview.chromium.org/2899783002/diff/720001/components/ui_devtools...
components/ui_devtools/views/BUILD.gn:52: "//components/ui_devtools",
Can you remove this dependency, and remove the UI_DEVTOOLS_IMPLEMENTATION
defines from both source_sets in this file? And see if that helps with win build
failures? Because adding the UI_DEV... define in these target is the wrong thing
to do I believe.

[thanhph, 2017-06-08 22:27:24]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 22:27:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 00:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 00:18:29]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[thanhph, 2017-06-09 16:03:04]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 16:03:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 16:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 16:08:48]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph, 2017-06-09 16:34:03]

Patchset #10 (id:760001) has been deleted

[thanhph, 2017-06-12 13:37:53]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 13:38:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 13:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 13:42:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[thanhph, 2017-06-12 13:46:42]

Patchset #10 (id:780001) has been deleted

[thanhph, 2017-06-12 13:56:38]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 13:56:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 15:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 15:44:50]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-13 04:52:13]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 04:52:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 06:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 06:09:20]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[thanhph, 2017-06-13 17:37:01]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 17:37:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-06-13 19:01:43]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 19:02:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 22:41:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 22:41:48]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-14 01:35:53]

Please review my new patch, thanks!

Thanh.

https://codereview.chromium.org/2899783002/diff/720001/components/ui_devtools...
File components/ui_devtools/views/BUILD.gn (right):

https://codereview.chromium.org/2899783002/diff/720001/components/ui_devtools...
components/ui_devtools/views/BUILD.gn:52: "//components/ui_devtools",
On 2017/06/08 22:08:01, sadrul wrote:
> Can you remove this dependency, and remove the UI_DEVTOOLS_IMPLEMENTATION
> defines from both source_sets in this file? And see if that helps with win
build
> failures? Because adding the UI_DEV... define in these target is the wrong
thing
> to do I believe.

Done, thanks! I use component build as we discussed.

[sadrul, 2017-06-14 03:25:58]

Some nits. gtlm with those addressed.

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/DEPS (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/DEPS:3: "+third_party/skia/include/core"
sort

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_css_agent.h (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_css_agent.h:16: : public
NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
You should no longer need NON_EXPORTED_BASE here.

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:347: params.parent =
root_windows()[0];
This should be going away soon
(https://bugs.chromium.org/p/chromium/issues/detail?id=730828). So this is OK
for now.

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_dom_agent.h (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.h:31: : public
NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
You should not need NON_EXPORTED_BASE.

[thanhph, 2017-06-14 13:58:32]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 13:58:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 15:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 15:18:16]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-14 15:26:37]

Thanks Sadrul. Please review my new patch.

Thanh.

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/DEPS (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/DEPS:3: "+third_party/skia/include/core"
On 2017/06/14 03:25:57, sadrul wrote:
> sort

Done.

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_css_agent.h (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_css_agent.h:16: : public
NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
On 2017/06/14 03:25:57, sadrul wrote:
> You should no longer need NON_EXPORTED_BASE here.

Done.

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.cc:347: params.parent =
root_windows()[0];
On 2017/06/14 03:25:57, sadrul wrote:
> This should be going away soon
> (https://bugs.chromium.org/p/chromium/issues/detail?id=730828). So this is OK
> for now.

Acknowledged.

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
File components/ui_devtools/views/ui_devtools_dom_agent.h (right):

https://codereview.chromium.org/2899783002/diff/860001/components/ui_devtools...
components/ui_devtools/views/ui_devtools_dom_agent.h:31: : public
NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
On 2017/06/14 03:25:57, sadrul wrote:
> You should not need NON_EXPORTED_BASE.

Done.

[sadrul, 2017-06-14 17:30:43]

lgtm

[thanhph, 2017-06-14 17:31:26]

The CQ bit was checked by thanhph@chromium.org

[commit-bot: I haz the power, 2017-06-14 17:31:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 17:40:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 17:40:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[thanhph, 2017-06-14 17:41:07]

The CQ bit was checked by thanhph@chromium.org

[commit-bot: I haz the power, 2017-06-14 17:41:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 17:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 17:52:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[thanhph, 2017-06-14 18:21:00]

thanhph@chromium.org changed reviewers:
+ blundell@chromium.org

[thanhph, 2017-06-14 18:21:02]

blundell@: Hi Colin, please review my changes in components folder. Thanks!

[thanhph, 2017-06-14 18:23:27]

thanhph@chromium.org changed reviewers:
+ derat@chromium.org

[thanhph, 2017-06-14 18:23:29]

derat@chromium.org: Hi Dan, please review my changes in ash folder. I basically
just moved DevTools out of ash here. Thanks!

[Daniel Erat, 2017-06-14 18:55:58]

rubber-stamp lgtm for //ash

[blundell, 2017-06-19 13:33:01]

addition of component lgtm with some nits

apologies for the delay, this message slipped off my radar and I have been
checking rietveld less than I used to :(

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
File components/ui_devtools/BUILD.gn (right):

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
components/ui_devtools/BUILD.gn:55: component("ui_devtools") {
could you find some OWNERS for this component and add a README describing it? I
don't know offhand how it differs from the other directories in the codebase
named "devtools".

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
File components/ui_devtools/devtools_client.h (right):

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
components/ui_devtools/devtools_client.h:16: namespace ui {
the namespace for this code should now be ui_devtools

[thanhph, 2017-06-20 01:19:55]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 01:20:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 03:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 03:18:15]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-20 17:32:25]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 17:32:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2017-06-20 17:40:28]

Thanks Dan and Colin for your stamps. 

Colin: I just addressed your comments in the latest patch.

Thanh.

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
File components/ui_devtools/BUILD.gn (right):

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
components/ui_devtools/BUILD.gn:55: component("ui_devtools") {
On 2017/06/19 13:33:00, blundell wrote:
> could you find some OWNERS for this component and add a README describing it?
I
> don't know offhand how it differs from the other directories in the codebase
> named "devtools".

Done. I added a README.md. sadrul@ and dgozman@ are current owners of this
folder.

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
File components/ui_devtools/devtools_client.h (right):

https://codereview.chromium.org/2899783002/diff/880001/components/ui_devtools...
components/ui_devtools/devtools_client.h:16: namespace ui {
On 2017/06/19 13:33:00, blundell wrote:
> the namespace for this code should now be ui_devtools

Done. I use ui_devtools namespace for all relevant files in this folder.

[commit-bot: I haz the power, 2017-06-20 19:01:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 19:01:25]

Dry run: This issue passed the CQ dry run.

[thanhph, 2017-06-20 21:28:21]

The CQ bit was checked by thanhph@chromium.org

[thanhph, 2017-06-20 21:28:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
derat@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2899783002/#ps920001
(title: "add README.md")

[commit-bot: I haz the power, 2017-06-20 21:28:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 21:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 21:40:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[thanhph, 2017-06-20 22:28:08]

thanhph@chromium.org changed reviewers:
+ sky@chromium.org

[thanhph, 2017-06-20 22:28:10]

Hi Scott,

Could you review my changes in chrome/browser/ui/webui/inspect_ui.cc? I just
simply change the namespace of devtools?

Thanks,
Thanh.

[sky, 2017-06-21 00:27:35]

LGTM

[thanhph, 2017-06-21 00:29:30]

The CQ bit was checked by thanhph@chromium.org

[commit-bot: I haz the power, 2017-06-21 00:30:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 00:37:29]

CQ is committing da patch.

Bot data: {"patchset_id": 920001, "attempt_start_ts": 1498004970609070,
"parent_rev": "3db9563bba1d755372c662cebb6402a4cc43e0e5", "commit_rev":
"3f39685180b85f09614e287f1150dabfc9fa9d05"}

[commit-bot: I haz the power, 2017-06-21 00:37:45]

Description was changed from

==========
Move DevTools out of ash and turn it to a component. AshTestbase
dependency will be removed and replaced by ViewTestBase. Appropriate 
UIElement trees are also created to test DevTools.

BUG=701835
==========

to

==========
Move DevTools out of ash and turn it to a component. AshTestbase
dependency will be removed and replaced by ViewTestBase. Appropriate 
UIElement trees are also created to test DevTools.

BUG=701835

Review-Url: https://codereview.chromium.org/2899783002
Cr-Commit-Position: refs/heads/master@{#481047}
Committed:
https://chromium.googlesource.com/chromium/src/+/3f39685180b85f09614e287f1150...
==========

[commit-bot: I haz the power, 2017-06-21 00:37:47]

Committed patchset #16 (id:920001) as
https://chromium.googlesource.com/chromium/src/+/3f39685180b85f09614e287f1150...