Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2899783002: Move DevTools out of ash and turn it to a component. (Closed)
Patch Set: add README.md Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/shell.cc ('k') | chrome/browser/ui/webui/inspect_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2713 matching lines...) Expand 10 before | Expand all | Expand 10 after
2724 kOsAndroid, 2724 kOsAndroid,
2725 FEATURE_WITH_PARAMS_VALUE_TYPE( 2725 FEATURE_WITH_PARAMS_VALUE_TYPE(
2726 autofill::kAutofillCreditCardPopupLayout, 2726 autofill::kAutofillCreditCardPopupLayout,
2727 kAutofillCreditCardPopupLayoutFeatureVariations, 2727 kAutofillCreditCardPopupLayoutFeatureVariations,
2728 // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash 2728 // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash
2729 // when the flag is manually enabled in a local build. 2729 // when the flag is manually enabled in a local build.
2730 "AutofillCreditCardDropdownVariations")}, 2730 "AutofillCreditCardDropdownVariations")},
2731 #endif // OS_ANDROID 2731 #endif // OS_ANDROID
2732 2732
2733 #if defined(OS_CHROMEOS) 2733 #if defined(OS_CHROMEOS)
2734 {ui::devtools::kEnableUiDevTools, flag_descriptions::kUiDevToolsName, 2734 {ui_devtools::kEnableUiDevTools, flag_descriptions::kUiDevToolsName,
2735 flag_descriptions::kUiDevToolsDescription, kOsCrOS, 2735 flag_descriptions::kUiDevToolsDescription, kOsCrOS,
2736 SINGLE_VALUE_TYPE(ui::devtools::kEnableUiDevTools)}, 2736 SINGLE_VALUE_TYPE(ui_devtools::kEnableUiDevTools)},
2737 #endif // defined(OS_CHROMEOS) 2737 #endif // defined(OS_CHROMEOS)
2738 2738
2739 {"enable-autofill-credit-card-last-used-date-display", 2739 {"enable-autofill-credit-card-last-used-date-display",
2740 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplayName, 2740 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplayName,
2741 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplayDescription, 2741 flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplayDescription,
2742 kOsAll, 2742 kOsAll,
2743 FEATURE_WITH_PARAMS_VALUE_TYPE( 2743 FEATURE_WITH_PARAMS_VALUE_TYPE(
2744 autofill::kAutofillCreditCardLastUsedDateDisplay, 2744 autofill::kAutofillCreditCardLastUsedDateDisplay,
2745 kAutofillCreditCardLastUsedDateFeatureVariations, 2745 kAutofillCreditCardLastUsedDateFeatureVariations,
2746 // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash 2746 // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
3120 3120
3121 #if defined(OS_CHROMEOS) 3121 #if defined(OS_CHROMEOS)
3122 // Don't expose --mash/--mus outside of Canary or developer builds. 3122 // Don't expose --mash/--mus outside of Canary or developer builds.
3123 if (!strcmp("mus", entry.internal_name) && 3123 if (!strcmp("mus", entry.internal_name) &&
3124 channel != version_info::Channel::DEV && 3124 channel != version_info::Channel::DEV &&
3125 channel != version_info::Channel::UNKNOWN) { 3125 channel != version_info::Channel::UNKNOWN) {
3126 return true; 3126 return true;
3127 } 3127 }
3128 3128
3129 // enable-ui-devtools is only available on for non Stable channels. 3129 // enable-ui-devtools is only available on for non Stable channels.
3130 if (!strcmp(ui::devtools::kEnableUiDevTools, entry.internal_name) && 3130 if (!strcmp(ui_devtools::kEnableUiDevTools, entry.internal_name) &&
3131 channel == version_info::Channel::STABLE) { 3131 channel == version_info::Channel::STABLE) {
3132 return true; 3132 return true;
3133 } 3133 }
3134 #endif // defined(OS_CHROMEOS) 3134 #endif // defined(OS_CHROMEOS)
3135 3135
3136 // data-reduction-proxy-lo-fi and enable-data-reduction-proxy-lite-page 3136 // data-reduction-proxy-lo-fi and enable-data-reduction-proxy-lite-page
3137 // are only available for Chromium builds and the Canary/Dev/Beta channels. 3137 // are only available for Chromium builds and the Canary/Dev/Beta channels.
3138 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) || 3138 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) ||
3139 !strcmp("enable-data-reduction-proxy-lite-page", entry.internal_name)) && 3139 !strcmp("enable-data-reduction-proxy-lite-page", entry.internal_name)) &&
3140 channel != version_info::Channel::BETA && 3140 channel != version_info::Channel::BETA &&
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
3290 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3290 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3291 3291
3292 const FeatureEntry* GetFeatureEntries(size_t* count) { 3292 const FeatureEntry* GetFeatureEntries(size_t* count) {
3293 *count = arraysize(kFeatureEntries); 3293 *count = arraysize(kFeatureEntries);
3294 return kFeatureEntries; 3294 return kFeatureEntries;
3295 } 3295 }
3296 3296
3297 } // namespace testing 3297 } // namespace testing
3298 3298
3299 } // namespace about_flags 3299 } // namespace about_flags
OLDNEW
« no previous file with comments | « ash/shell.cc ('k') | chrome/browser/ui/webui/inspect_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698