Move DevTools out of ash and turn it to a component.

components/ui_devtools/views/BUILD.gn

+import("//build/config/ui.gni")
+
+source_set("views") {
+  defines = [ "UI_DEVTOOLS_IMPLEMENTATION" ]
+
+  cflags = []
+  if (is_win) {
+    cflags += [ "/wd4800" ]  # Value forced to bool.
+  }
+
+  sources = [
+    "ui_devtools_css_agent.cc",
+    "ui_devtools_css_agent.h",
+    "ui_devtools_dom_agent.cc",
+    "ui_devtools_dom_agent.h",
+    "ui_element.cc",
+    "ui_element.h",
+    "ui_element_delegate.h",
+    "view_element.cc",
+    "view_element.h",
+    "widget_element.cc",
+    "widget_element.h",
+    "window_element.cc",
+    "window_element.h",
+  ]
+
+  deps = [
+    "//components/ui_devtools",
+    "//skia",
+    "//ui/aura",
+    "//ui/views",
+    "//ui/wm:wm",
+  ]
+}
+
+source_set("unit_tests") {
+  testonly = true
+
+  defines = [ "UI_DEVTOOLS_IMPLEMENTATION" ]
+
+  cflags = []
+  if (is_win) {
+    cflags += [ "/wd4800" ]  # Value forced to bool.
+  }
+
+  sources = [
+    "ui_devtools_unittest.cc",
+  ]
+
+  deps = [
+    ":views",
+    "//components/ui_devtools",

[sadrul, 2017/06/08 22:08:01]

Can you remove this dependency, and remove the UI_DEVTOOLS_IMPLEMENTATION
defines from both source_sets in this file? And see if that helps with win build
failures? Because adding the UI_DEV... define in these target is the wrong thing
to do I believe.

[thanhph, 2017/06/14 01:35:53]

Done, thanks! I use component build as we discussed.

+    "//skia",
+    "//testing/gtest",
+    "//ui/aura",
+    "//ui/views",
+    "//ui/views:test_support",
+    "//ui/wm:wm",
+  ]
+
+  configs += [ "//build/config:precompiled_headers" ]
+}