Add missing dependencies on exe_and_shlib_deps (Chromium repo)

Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng

Review-Url: https://codereview.chromium.org/2899403004
Cr-Commit-Position: refs/heads/master@{#475059}
Committed: https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77dade846aca69

[Tom Anderson, 2017-05-25 01:24:17]

Description was changed from

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
==========

to

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Tom Anderson, 2017-05-25 01:28:48]

Description was changed from

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

[Tom Anderson, 2017-05-25 01:28:55]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 01:30:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-25 03:33:23]

brettw ptal

[Tom Anderson, 2017-05-25 03:35:25]

Description was changed from

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

to

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

Corresponding boringssl change:
https://boringssl-review.googlesource.com/c/16664/

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

[Tom Anderson, 2017-05-25 03:35:58]

Description was changed from

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

Corresponding boringssl change:
https://boringssl-review.googlesource.com/c/16664/

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

to

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

Corresponding change for the generated boringssl file:
https://boringssl-review.googlesource.com/c/16664/

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

[commit-bot: I haz the power, 2017-05-25 04:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:50:55]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-05-25 17:51:40]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2017-05-25 17:51:41]

https://codereview.chromium.org/2899403004/diff/1/third_party/boringssl/BUILD...
File third_party/boringssl/BUILD.generated_tests.gni (right):

https://codereview.chromium.org/2899403004/diff/1/third_party/boringssl/BUILD...
third_party/boringssl/BUILD.generated_tests.gni:1: # Copyright (c) 2016 The
Chromium Authors. All rights reserved.
I was actually planning on doing a BoringSSL roll today anyway
(https://codereview.chromium.org/2906523002/, supposing the try bots like it),
which would pick up your change and refresh this file.

(But I also don't object to you landing this in this CL. Just less rebasing
nuisances for one of us.)

[Tom Anderson, 2017-05-25 21:19:47]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:20:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-25 21:25:19]

Patchset #2 (id:20001) has been deleted

[Tom Anderson, 2017-05-25 21:27:50]

Patchset #2 (id:40001) has been deleted

[Tom Anderson, 2017-05-25 21:28:34]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:29:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-25 21:29:32]

On 2017/05/25 17:51:41, davidben wrote:
>
https://codereview.chromium.org/2899403004/diff/1/third_party/boringssl/BUILD...
> File third_party/boringssl/BUILD.generated_tests.gni (right):
> 
>
https://codereview.chromium.org/2899403004/diff/1/third_party/boringssl/BUILD...
> third_party/boringssl/BUILD.generated_tests.gni:1: # Copyright (c) 2016 The
> Chromium Authors. All rights reserved.
> I was actually planning on doing a BoringSSL roll today anyway
> (https://codereview.chromium.org/2906523002/, supposing the try bots like it),
> which would pick up your change and refresh this file.
> 
> (But I also don't object to you landing this in this CL. Just less rebasing
> nuisances for one of us.)

Ah, it appears you already landed that patch :)
I've reverted the boringssl changes in the latest patch set.

[Tom Anderson, 2017-05-25 21:29:54]

Description was changed from

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

Corresponding change for the generated boringssl file:
https://boringssl-review.googlesource.com/c/16664/

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

to

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

[commit-bot: I haz the power, 2017-05-25 23:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 23:03:03]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Tom Anderson, 2017-05-25 23:08:22]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:08:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-05-26 01:06:55]

pinging brettw@

[commit-bot: I haz the power, 2017-05-26 04:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 04:13:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tom Anderson, 2017-05-26 05:31:48]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 05:32:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 07:09:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 07:09:35]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-05-26 17:30:00]

lgtm

[Tom (Use chromium acct), 2017-05-26 18:01:05]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-05-26 18:02:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 18:09:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495821665080890,
"parent_rev": "c45f50742410a644a054325478d885e61d286713", "commit_rev":
"9e926233bf660c42676d6bd4cb77dade846aca69"}

[commit-bot: I haz the power, 2017-05-26 18:09:24]

Description was changed from

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
==========

to

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng

Review-Url: https://codereview.chromium.org/2899403004
Cr-Commit-Position: refs/heads/master@{#475059}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77...
==========

[commit-bot: I haz the power, 2017-05-26 18:09:25]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77...

[nednguyen, 2017-05-26 19:02:45]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2912513002/ by nednguyen@google.com.

The reason for reverting is: BUG=726808

Suspecting causing generate_build_files failure (according to FindIt).

[Tom Anderson, 2017-05-26 19:08:59]

Description was changed from

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng

Review-Url: https://codereview.chromium.org/2899403004
Cr-Commit-Position: refs/heads/master@{#475059}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77...
==========

to

==========
Add missing dependencies on exe_and_shlib_deps (Chromium repo)

BUG=723069
R=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng

Review-Url: https://codereview.chromium.org/2899403004
Cr-Commit-Position: refs/heads/master@{#475059}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77...
==========