Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2748443003: Add exception in GLibLogHandler for Gtk theme warning (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
Reviewers:
Tom Anderson, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add exception in GLibLogHandler for Gtk theme warning BUG=700117 TBR=boliu@chromium.org Review-Url: https://codereview.chromium.org/2748443003 Cr-Commit-Position: refs/heads/master@{#456194} Committed: https://chromium.googlesource.com/chromium/src/+/b833579e84a9f94763f96f84f04a9279cc560057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Tom Anderson
boliu@ ptal lgtm from my chromium account in the meantime
3 years, 9 months ago (2017-03-10 20:45:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748443003/1
3 years, 9 months ago (2017-03-10 20:46:54 UTC) #6
boliu
rs lgtm
3 years, 9 months ago (2017-03-10 20:51:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/404790)
3 years, 9 months ago (2017-03-10 21:48:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748443003/1
3 years, 9 months ago (2017-03-10 22:29:17 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 22:40:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b833579e84a9f94763f96f84f04a...

Powered by Google App Engine
This is Rietveld 408576698