Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2906523002: Roll src/third_party/boringssl/src 467d3220f..68f84f5c4 (Closed)

Created:
3 years, 7 months ago by davidben
Modified:
3 years, 7 months ago
Reviewers:
svaldez
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : roll further #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -128 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.generated.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/boringssl/BUILD.generated_tests.gni View 1 23 chunks +33 lines, -126 lines 0 comments Download
A third_party/boringssl/crypto_test_data.cc View 1 chunk +114 lines, -0 lines 1 comment Download
M third_party/boringssl/roll_boringssl.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
davidben
3 years, 7 months ago (2017-05-25 17:55:23 UTC) #9
svaldez
lgtm https://codereview.chromium.org/2906523002/diff/20001/third_party/boringssl/crypto_test_data.cc File third_party/boringssl/crypto_test_data.cc (right): https://codereview.chromium.org/2906523002/diff/20001/third_party/boringssl/crypto_test_data.cc#newcode106 third_party/boringssl/crypto_test_data.cc:106: if (strcmp(path, "crypto/curve25519/ed25519_tests.txt") == 0) { Eventually you'll ...
3 years, 7 months ago (2017-05-25 17:57:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906523002/20001
3 years, 7 months ago (2017-05-25 17:59:14 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 20:06:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df3c9bc828ab4781e1dc5b51a95f...

Powered by Google App Engine
This is Rietveld 408576698