chromeos: Rename ash::WmShelf to Shelf

chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
R=msw@chromium.org, tsepez@chromium.org
TBR=reveman@chromium.org, xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2899253002 .
Cr-Commit-Position: refs/heads/master@{#474526}
Committed: https://chromium.googlesource.com/chromium/src/+/840177e705e9f12b06d2c80c6cd0d5c3d6b8b9e3

[James Cook, 2017-05-24 08:44:20]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 08:44:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-24 08:52:37]

Description was changed from

==========
chromeos: Rename ash WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Then fix up a couple call sites like "wm_shelf_container" window.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
==========

to

==========
chromeos: Rename ash WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
==========

[James Cook, 2017-05-24 08:54:22]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 08:54:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-24 09:27:54]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 09:28:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-24 09:28:58]

Description was changed from

==========
chromeos: Rename ash WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
==========

to

==========
chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
==========

[James Cook, 2017-05-24 09:30:35]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-05-24 09:30:38]

msw, please take a look.

https://codereview.chromium.org/2899253002/diff/40001/ash/root_window_control...
File ash/root_window_controller.h (right):

https://codereview.chromium.org/2899253002/diff/40001/ash/root_window_control...
ash/root_window_controller.h:142: Shelf* GetShelf() const { return shelf_.get();
}
I didn't fix this because the CL was getting too big -- it's not that many
calls, but most of the lines aren't touched by this CL. I fixed a couple in
passing.

[commit-bot: I haz the power, 2017-05-24 11:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 11:02:52]

Dry run: This issue passed the CQ dry run.

[msw, 2017-05-24 18:42:58]

lgtm with optional nits

https://codereview.chromium.org/2899253002/diff/40001/ash/app_list/app_list_p...
File ash/app_list/app_list_presenter_delegate.h (right):

https://codereview.chromium.org/2899253002/diff/40001/ash/app_list/app_list_p...
ash/app_list/app_list_presenter_delegate.h:73: void
OnShelfIconPositionsChanged() override;
aside: I think we could remove this now (or in a followup), the app list
position no longer depends on the app list button's position.

https://codereview.chromium.org/2899253002/diff/40001/ash/root_window_control...
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2899253002/diff/40001/ash/root_window_control...
ash/root_window_controller.cc:711: shelf_(base::MakeUnique<Shelf>()) {
aside: perhaps this doesn't even need to be a unique_ptr

https://codereview.chromium.org/2899253002/diff/40001/ash/root_window_control...
File ash/root_window_controller.h (right):

https://codereview.chromium.org/2899253002/diff/40001/ash/root_window_control...
ash/root_window_controller.h:142: Shelf* GetShelf() const { return shelf_.get();
}
On 2017/05/24 09:30:37, James Cook wrote:
> I didn't fix this because the CL was getting too big -- it's not that many
> calls, but most of the lines aren't touched by this CL. I fixed a couple in
> passing.

Acknowledged.

https://codereview.chromium.org/2899253002/diff/40001/ash/shelf/shelf.h
File ash/shelf/shelf.h (left):

https://codereview.chromium.org/2899253002/diff/40001/ash/shelf/shelf.h#oldco...
ash/shelf/shelf.h:75: ShelfAlignment GetAlignment() const { return alignment_; }
nice!

https://codereview.chromium.org/2899253002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2899253002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:637: change_work_area) {
optional nit: reorder this to be the second conditional term

[James Cook, 2017-05-24 19:28:16]

jamescook@chromium.org changed reviewers:
+ reveman@chromium.org

[James Cook, 2017-05-24 19:28:17]

TBR reveman for trivial rename touching exo

I'll do the nits in a follow-up, I'd like to land this given our impending
branch.

[James Cook, 2017-05-24 19:28:37]

Description was changed from

==========
chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
==========

to

==========
chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
TBR=reveman@chromium.org
==========

[James Cook, 2017-05-24 19:28:49]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:29:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-24 19:32:17]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-05-24 19:51:28]

Description was changed from

==========
chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
TBR=reveman@chromium.org
==========

to

==========
chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
TBR=reveman@chromium.org,tsepez@chromium.org,xiyuan@chromium.org
==========

[James Cook, 2017-05-24 19:52:11]

jamescook@chromium.org changed reviewers:
+ tsepez@chromium.org, xiyuan@chromium.org

[James Cook, 2017-05-24 19:52:12]

TBR tsepez for rename touching ash/public/interfaces/shelf.mojom

TBR xiyuan for rename touching chrome/browser/chromeos

[James Cook, 2017-05-24 19:52:25]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-05-24 19:52:27]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2899253002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-24 19:53:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 20:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 20:05:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Sepez, 2017-05-24 20:09:56]

lgtm

RS

[James Cook, 2017-05-24 20:14:44]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-05-24 20:15:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-25 02:18:34]

On 2017/05/24 20:15:10, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

The android timeouts are unrelated to this CL (this code doesn't even compile on
android). I'm going to land.

[James Cook, 2017-05-25 02:20:56]

Description was changed from

==========
chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
TBR=reveman@chromium.org,tsepez@chromium.org,xiyuan@chromium.org
==========

to

==========
chromeos: Rename ash::WmShelf to Shelf

The "Wm" porting layer is being removed, so it can go back to its
original name.

No behavior changes, just a mechanical refactor.

tools/git/move_source_file.py for
    wm_shelf.h to shelf.h
    wm_shelf.cc to shelf.cc
    wm_shelf_observer.h to shelf_observer.h

tools/git/mffr.py for
  WmShelfObserver to ShelfObserver
  WmShelf to Shelf
  wm_shelf to shelf

Fix up a couple call sites like "wm_shelf_container" window.

Replace deprecated GetAlignment() with alignment() because it touches
the same lines as the rest of this change.

BUG=none
TEST=compiles, ash_unittests, chrome unit_tests
R=msw@chromium.org, tsepez@chromium.org
TBR=reveman@chromium.org, xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2899253002 .
Cr-Commit-Position: refs/heads/master@{#474526}
Committed:
https://chromium.googlesource.com/chromium/src/+/840177e705e9f12b06d2c80c6cd0...
==========

[James Cook, 2017-05-25 02:20:59]

Committed patchset #4 (id:60001) manually as
840177e705e9f12b06d2c80c6cd0d5c3d6b8b9e3 (presubmit successful).

[reveman, 2017-05-25 11:05:10]

lgtm