Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: ash/metrics/user_metrics_recorder.cc

Issue 2899253002: chromeos: Rename ash::WmShelf to Shelf (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/focus_cycler_unittest.cc ('k') | ash/mus/context_menu_mus.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/metrics/user_metrics_recorder.h" 5 #include "ash/metrics/user_metrics_recorder.h"
6 6
7 #include "ash/metrics/desktop_task_switch_metric_recorder.h" 7 #include "ash/metrics/desktop_task_switch_metric_recorder.h"
8 #include "ash/metrics/pointer_metrics_recorder.h" 8 #include "ash/metrics/pointer_metrics_recorder.h"
9 #include "ash/public/cpp/shelf_item.h" 9 #include "ash/public/cpp/shelf_item.h"
10 #include "ash/public/cpp/shell_window_ids.h" 10 #include "ash/public/cpp/shell_window_ids.h"
11 #include "ash/session/session_controller.h" 11 #include "ash/session/session_controller.h"
12 #include "ash/session/session_state_delegate.h" 12 #include "ash/session/session_state_delegate.h"
13 #include "ash/shelf/shelf.h"
13 #include "ash/shelf/shelf_model.h" 14 #include "ash/shelf/shelf_model.h"
14 #include "ash/shelf/shelf_view.h" 15 #include "ash/shelf/shelf_view.h"
15 #include "ash/shelf/wm_shelf.h"
16 #include "ash/shell.h" 16 #include "ash/shell.h"
17 #include "ash/wm/window_state.h" 17 #include "ash/wm/window_state.h"
18 #include "ash/wm_window.h" 18 #include "ash/wm_window.h"
19 #include "base/memory/ptr_util.h" 19 #include "base/memory/ptr_util.h"
20 #include "base/metrics/histogram_macros.h" 20 #include "base/metrics/histogram_macros.h"
21 #include "base/metrics/user_metrics.h" 21 #include "base/metrics/user_metrics.h"
22 #include "ui/aura/window.h" 22 #include "ui/aura/window.h"
23 23
24 namespace ash { 24 namespace ash {
25 25
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 void UserMetricsRecorder::OnShellShuttingDown() { 617 void UserMetricsRecorder::OnShellShuttingDown() {
618 desktop_task_switch_metric_recorder_.reset(); 618 desktop_task_switch_metric_recorder_.reset();
619 619
620 // To clean up pointer_metrics_recorder_ properly, a valid shell instance is 620 // To clean up pointer_metrics_recorder_ properly, a valid shell instance is
621 // required, so explicitly delete it before the shell instance becomes 621 // required, so explicitly delete it before the shell instance becomes
622 // invalid. 622 // invalid.
623 pointer_metrics_recorder_.reset(); 623 pointer_metrics_recorder_.reset();
624 } 624 }
625 625
626 void UserMetricsRecorder::RecordPeriodicMetrics() { 626 void UserMetricsRecorder::RecordPeriodicMetrics() {
627 WmShelf* shelf = WmShelf::ForWindow(Shell::GetPrimaryRootWindow()); 627 Shelf* shelf = Shelf::ForWindow(Shell::GetPrimaryRootWindow());
628 // TODO(bruthig): Investigating whether the check for |manager| is necessary 628 // TODO(bruthig): Investigating whether the check for |manager| is necessary
629 // and add tests if it is. 629 // and add tests if it is.
630 if (shelf) { 630 if (shelf) {
631 // TODO(bruthig): Consider tracking the time spent in each alignment. 631 // TODO(bruthig): Consider tracking the time spent in each alignment.
632 UMA_HISTOGRAM_ENUMERATION("Ash.ShelfAlignmentOverTime", 632 UMA_HISTOGRAM_ENUMERATION("Ash.ShelfAlignmentOverTime",
633 shelf->SelectValueForShelfAlignment( 633 shelf->SelectValueForShelfAlignment(
634 SHELF_ALIGNMENT_UMA_ENUM_VALUE_BOTTOM, 634 SHELF_ALIGNMENT_UMA_ENUM_VALUE_BOTTOM,
635 SHELF_ALIGNMENT_UMA_ENUM_VALUE_LEFT, 635 SHELF_ALIGNMENT_UMA_ENUM_VALUE_LEFT,
636 SHELF_ALIGNMENT_UMA_ENUM_VALUE_RIGHT), 636 SHELF_ALIGNMENT_UMA_ENUM_VALUE_RIGHT),
637 SHELF_ALIGNMENT_UMA_ENUM_VALUE_COUNT); 637 SHELF_ALIGNMENT_UMA_ENUM_VALUE_COUNT);
(...skipping 18 matching lines...) Expand all
656 return IsUserActive() && !IsKioskModeActive() && !IsArcKioskModeActive(); 656 return IsUserActive() && !IsKioskModeActive() && !IsArcKioskModeActive();
657 } 657 }
658 658
659 void UserMetricsRecorder::StartTimer() { 659 void UserMetricsRecorder::StartTimer() {
660 timer_.Start(FROM_HERE, 660 timer_.Start(FROM_HERE,
661 base::TimeDelta::FromSeconds(kAshPeriodicMetricsTimeInSeconds), 661 base::TimeDelta::FromSeconds(kAshPeriodicMetricsTimeInSeconds),
662 this, &UserMetricsRecorder::RecordPeriodicMetrics); 662 this, &UserMetricsRecorder::RecordPeriodicMetrics);
663 } 663 }
664 664
665 } // namespace ash 665 } // namespace ash
OLDNEW
« no previous file with comments | « ash/focus_cycler_unittest.cc ('k') | ash/mus/context_menu_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698