Removed NativeAppsCollectionViewController and related code.

Removed NativeAppsCollectionViewController and related code.

After the deprecation of Native App Launcher, this code is no longer
accessible.

BUG=721921
Review-Url: https://codereview.chromium.org/2899213002
Cr-Commit-Position: refs/heads/master@{#481836}
Committed: https://chromium.googlesource.com/chromium/src/+/8e7ebe52367879faf4952e74a06827c88f2895dd

[pkl (ping after 24h if needed), 2017-06-22 11:32:32]

pkl@chromium.org changed reviewers:
+ lpromero@chromium.org, rohitrao@chromium.org

[lpromero, 2017-06-22 11:44:40]

LGTM, can you also remove:
ios/chrome/browser/native_app_launcher
ios/chrome/browser/ui/settings/cells/native_app_item*
ios/public/provider/chrome/browser/native_app_launcher?

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
ios/chrome/app/main_controller.mm:131: #import
"ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h"
Should this go?

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
ios/chrome/app/main_controller.mm:178: NSString* const kCheckNativeApps =
@"CheckNativeApps";
Should this go?

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
ios/chrome/app/main_controller.mm:457: - (void)scheduleCheckNativeApps;
Should this go?

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/BUILD.gn (right):

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/BUILD.gn:198: "StoreKit.framework",
Should this also be removed or are there other users of StoreKit in this target?

[lpromero, 2017-06-22 11:47:13]

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/BUILD.gn (right):

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/BUILD.gn:151: "//ios/chrome/browser/store_kit",
Might not be used anymore, but it needs to be checked.

[pkl (ping after 24h if needed), 2017-06-22 12:17:39]

On 2017/06/22 11:44:40, lpromero wrote:
> LGTM, can you also remove:
> ios/chrome/browser/native_app_launcher
> ios/chrome/browser/ui/settings/cells/native_app_item*
> ios/public/provider/chrome/browser/native_app_launcher?
> 
>
https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
> File ios/chrome/app/main_controller.mm (right):
> 
>
https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
> ios/chrome/app/main_controller.mm:131: #import
>
"ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h"
> Should this go?
> 
>
https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
> ios/chrome/app/main_controller.mm:178: NSString* const kCheckNativeApps =
> @"CheckNativeApps";
> Should this go?
> 
>
https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
> ios/chrome/app/main_controller.mm:457: - (void)scheduleCheckNativeApps;
> Should this go?
> 
>
https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
> File ios/chrome/browser/ui/settings/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
> ios/chrome/browser/ui/settings/BUILD.gn:198: "StoreKit.framework",
> Should this also be removed or are there other users of StoreKit in this
target?

ios/chrome/browser/native_app_launcher will be removed in
https://codereview.chromium.org/2897213002/
I have some other plans for
ios/public/provider/chrome/browser/native_app_launcher/ and that will go into
another CL.

[pkl (ping after 24h if needed), 2017-06-22 12:18:20]

lpromero: Thanks! Your comments addressed.

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
File ios/chrome/app/main_controller.mm (right):

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
ios/chrome/app/main_controller.mm:131: #import
"ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h"
On 2017/06/22 11:44:40, lpromero wrote:
> Should this go?

Not yet.

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
ios/chrome/app/main_controller.mm:178: NSString* const kCheckNativeApps =
@"CheckNativeApps";
On 2017/06/22 11:44:40, lpromero wrote:
> Should this go?

Not yet.

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/app/main_con...
ios/chrome/app/main_controller.mm:457: - (void)scheduleCheckNativeApps;
On 2017/06/22 11:44:40, lpromero wrote:
> Should this go?

This will go into a separate CL. There's some changes I would like to do related
to co-installation rate of apps.

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/BUILD.gn (right):

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/BUILD.gn:151: "//ios/chrome/browser/store_kit",
On 2017/06/22 11:47:13, lpromero wrote:
> Might not be used anymore, but it needs to be checked.

Not used. Removed.

https://codereview.chromium.org/2899213002/diff/20001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/BUILD.gn:198: "StoreKit.framework",
On 2017/06/22 11:44:40, lpromero wrote:
> Should this also be removed or are there other users of StoreKit in this
target?

Removed too.

[rohitrao (ping after 24h), 2017-06-22 15:09:56]

lgtm but I thought we were waiting for M60 to ship and M61 to branch, per the
linked bug

[pkl (ping after 24h if needed), 2017-06-23 08:18:48]

On 2017/06/22 15:09:56, rohitrao (ping after 24h) wrote:
> lgtm but I thought we were waiting for M60 to ship and M61 to branch, per the
> linked bug

Feature will be deprecated in M60, so code removal can happen before M61 branch.

[pkl (ping after 24h if needed), 2017-06-23 08:26:41]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-06-23 08:26:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2899213002/#ps80001
(title: "removed StoreKit.framework")

[commit-bot: I haz the power, 2017-06-23 08:26:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 09:37:28]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498206401658220,
"parent_rev": "6fd1487d6f52df3e7598a716e4095b408a0d6431", "commit_rev":
"8e7ebe52367879faf4952e74a06827c88f2895dd"}

[commit-bot: I haz the power, 2017-06-23 09:37:41]

Description was changed from

==========
Removed NativeAppsCollectionViewController and related code.

After the deprecation of Native App Launcher, this code is no longer
accessible.

BUG=721921
==========

to

==========
Removed NativeAppsCollectionViewController and related code.

After the deprecation of Native App Launcher, this code is no longer
accessible.

BUG=721921

Review-Url: https://codereview.chromium.org/2899213002
Cr-Commit-Position: refs/heads/master@{#481836}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e7ebe52367879faf4952e74a068...
==========

[commit-bot: I haz the power, 2017-06-23 09:37:43]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8e7ebe52367879faf4952e74a068...