Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2897213002: Removed NativeAppNavigationController and related code (Closed)

Created:
3 years, 7 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, msramek+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, liaoyuke+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, markusheintz_, huangml+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed NativeAppNavigationController and related code These are no longer being used. BUG=721921 Review-Url: https://codereview.chromium.org/2897213002 Cr-Commit-Position: refs/heads/master@{#481857} Committed: https://chromium.googlesource.com/chromium/src/+/9afd36cf279820b61a052866793227c015eb97a2

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -692 lines) Patch
M ios/chrome/app/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/browsing_data/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/native_app_launcher/BUILD.gn View 1 1 chunk +0 lines, -62 lines 0 comments Download
D ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm View 1 chunk +0 lines, -245 lines 0 comments Download
D ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm View 1 1 chunk +0 lines, -207 lines 0 comments Download
D ios/chrome/browser/native_app_launcher/native_app_navigation_util.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm View 1 chunk +0 lines, -29 lines 0 comments Download
D ios/chrome/browser/native_app_launcher/native_app_navigation_util_unittest.mm View 1 1 chunk +0 lines, -90 lines 0 comments Download
M ios/chrome/browser/tabs/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/downloads/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/test/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
pkl (ping after 24h if needed)
3 years, 6 months ago (2017-06-22 11:44:48 UTC) #2
lpromero
lgtm
3 years, 6 months ago (2017-06-22 11:47:35 UTC) #3
rohitrao (ping after 24h)
On 2017/06/22 11:47:35, lpromero wrote: > lgtm Per the linked bug, I thought we were ...
3 years, 6 months ago (2017-06-22 15:07:36 UTC) #4
rohitrao (ping after 24h)
code lgtm otherwise
3 years, 6 months ago (2017-06-22 15:10:32 UTC) #5
pkl (ping after 24h if needed)
On 2017/06/22 15:10:32, rohitrao (ping after 24h) wrote: > code lgtm otherwise Since native app ...
3 years, 6 months ago (2017-06-23 08:27:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897213002/20001
3 years, 6 months ago (2017-06-23 10:37:12 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 11:53:16 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9afd36cf279820b61a0528667932...

Powered by Google App Engine
This is Rietveld 408576698