Removed NativeAppsCollectionViewController and related code.

ios/chrome/app/main_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/app/main_controller.h"
 
 #include <memory>
 #include <string>
 
 #import <CoreSpotlight/CoreSpotlight.h>
@@ skipping 110 matching lines @@
 #import "ios/chrome/browser/ui/tabs/tab_strip_controller+tab_switcher_animation.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #import "ios/chrome/browser/ui/util/top_view_controller.h"
 #import "ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h"
 #include "ios/chrome/browser/xcallback_parameters.h"
 #include "ios/net/cookies/cookie_store_ios.h"
 #import "ios/net/crn_http_protocol_handler.h"
 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #include "ios/public/provider/chrome/browser/distribution/app_distribution_provider.h"
 #import "ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h"

[lpromero, 2017/06/22 11:44:40]

Should this go?

[pkl (ping after 24h if needed), 2017/06/22 12:18:19]

Not yet.

 #include "ios/public/provider/chrome/browser/signin/chrome_identity_service.h"
 #import "ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h"
 #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MDCTypographyAdditions/MDFRobotoFontLoader+MDCTypographyAdditions.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
 #include "ios/web/net/request_tracker_factory_impl.h"
 #include "ios/web/net/request_tracker_impl.h"
 #include "ios/web/net/web_http_protocol_handler_delegate.h"
 #import "ios/web/public/navigation_manager.h"
 #include "ios/web/public/web_capabilities.h"
@@ skipping 26 matching lines @@
 NSString* const kStartupAttemptReset = @"StartupAttempReset";
 
 // Constants for deferring memory debugging tools startup.
 NSString* const kMemoryDebuggingToolsStartup = @"MemoryDebuggingToolsStartup";
 
 // Constants for deferred check if it is necessary to send pings to
 // Chrome distribution related services.
 NSString* const kSendInstallPingIfNecessary = @"SendInstallPingIfNecessary";
 
 // Constants for deferring check of native iOS apps installed.
 NSString* const kCheckNativeApps = @"CheckNativeApps";

[lpromero, 2017/06/22 11:44:40]

Should this go?

[pkl (ping after 24h if needed), 2017/06/22 12:18:19]

Not yet.

 
 // Constants for deferred deletion of leftover user downloaded files.
 NSString* const kDeleteDownloads = @"DeleteDownloads";
 
 // Constants for deferred sending of queued feedback.
 NSString* const kSendQueuedFeedback = @"SendQueuedFeedback";
 
 // Constants for deferring the deletion of pre-upgrade crash reports.
 NSString* const kCleanupCrashReports = @"CleanupCrashReports";
 
@@ skipping 186 matching lines @@
                        identity:(ChromeIdentity*)identity
                     accessPoint:(signin_metrics::AccessPoint)accessPoint
                     promoAction:(signin_metrics::PromoAction)promoAction
                        callback:(ShowSigninCommandCompletionCallback)callback;
 // Wraps a callback with one that first checks if sign-in was completed
 // successfully and the profile wasn't swapped before invoking.
 - (ShowSigninCommandCompletionCallback)successfulSigninCompletion:
     (ProceduralBlock)callback;
 // Shows the Sync encryption passphrase (part of Settings).
 - (void)showSyncEncryptionPassphrase;
-// Shows the Native Apps Settings UI (part of Settings).
-- (void)showNativeAppsSettings;
 // Shows the Clear Browsing Data Settings UI (part of Settings).
 - (void)showClearBrowsingDataSettingsController;
 // Shows the Contextual search UI (part of Settings).
 - (void)showContextualSearchSettingsController;
 // Shows the tab switcher UI.
 - (void)showTabSwitcher;
 // Starts a voice search on the current BVC.
 - (void)startVoiceSearch;
 // Dismisses the tab switcher UI without animation into the given model.
 - (void)dismissTabSwitcherWithoutAnimationInModel:(TabModel*)tabModel;
@@ skipping 52 matching lines @@
 - (void)sendQueuedFeedback;
 // Called whenever an orientation change is received.
 - (void)orientationDidChange:(NSNotification*)notification;
 // Register to receive orientation change notification to update breakpad
 // report.
 - (void)registerForOrientationChangeNotifications;
 // Asynchronously creates the pref observers.
 - (void)schedulePrefObserverInitialization;
 // Asynchronously schedules a check for what other native iOS apps are currently
 // installed.
 - (void)scheduleCheckNativeApps;

[lpromero, 2017/06/22 11:44:40]

Should this go?

[pkl (ping after 24h if needed), 2017/06/22 12:18:19]

This will go into a separate CL. There's some changes I would like to do related
to co-installation rate of apps.

 // Asynchronously schedules pings to distribution services.
 - (void)scheduleAppDistributionPings;
 // Asynchronously schedule the init of the memoryDebuggerManager.
 - (void)scheduleMemoryDebuggingTools;
 // Asynchronously kick off regular free memory checks.
 - (void)startFreeMemoryMonitoring;
 // Asynchronously schedules the notification of the AuthenticationService.
 - (void)scheduleAuthenticationServiceNotification;
 // Asynchronously schedules the reset of the failed startup attempt counter.
 - (void)scheduleStartupAttemptReset;
@@ skipping 994 matching lines @@
             browsing_data::CalculateBeginDeleteTime(timePeriod);
         [ChromeWebViewFactory clearExternalCookies:browserState
                                           fromTime:beginDeleteTime
                                             toTime:base::Time::Max()];
       }
       break;
     }
     case IDC_RESET_ALL_WEBVIEWS:
       [self.currentBVC resetAllWebViews];
       break;
-    case IDC_SHOW_GOOGLE_APPS_SETTINGS:
-      [self showNativeAppsSettings];
-      break;
     case IDC_SHOW_CLEAR_BROWSING_DATA_SETTINGS:
       [self showClearBrowsingDataSettingsController];
       break;
     case IDC_SHOW_CONTEXTUAL_SEARCH_SETTINGS:
       [self showContextualSearchSettingsController];
       break;
     case IDC_CLOSE_MODALS:
       [self dismissModalDialogsWithCompletion:nil];
       break;
     case IDC_SHOW_ADD_ACCOUNT:
@@ skipping 649 matching lines @@
       return;
     }
     DCHECK_EQ(self.mainBVC, self.currentBVC);
     SigninManager* signinManager =
         ios::SigninManagerFactory::GetForBrowserState(browserState);
     if (signinManager->IsAuthenticated())
       callback();
   } copy];
 }
 
-- (void)showNativeAppsSettings {
-  if (_settingsNavigationController)
-    return;
-  _settingsNavigationController =
-      [SettingsNavigationController newNativeAppsController:_mainBrowserState
-                                                   delegate:self];
-  [[self topPresentedViewController]
-      presentViewController:_settingsNavigationController
-                   animated:YES
-                 completion:nil];
-}
-
 - (void)closeSettingsAnimated:(BOOL)animated
                    completion:(ProceduralBlock)completion {
   DCHECK(_settingsNavigationController);
   [_settingsNavigationController settingsWillBeDismissed];
   UIViewController* presentingViewController =
       [_settingsNavigationController presentingViewController];
   DCHECK(presentingViewController);
   [presentingViewController dismissViewControllerAnimated:animated
                                                completion:^{
                                                  if (completion)
@@ skipping 412 matching lines @@
   };
 
   callbackCounter->IncrementCount();
   [self removeBrowsingDataFromBrowserState:_mainBrowserState
                                       mask:removeAllMask
                                 timePeriod:browsing_data::TimePeriod::ALL_TIME
                          completionHandler:decrementCallbackCounterCount];
 }
 
 @end