Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2899033002: Revert of [Cast,Android] Replace custom MediaController with android.widget.MediaController. (Closed)

Created:
3 years, 7 months ago by whywhat
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert of [Cast,Android] Replace custom MediaController with android.widget.MediaController. (patchset #1 id:1 of https://codereview.chromium.org/2888273002/ ) Reason for revert: Caused https://bugs.chromium.org/p/chromium/issues/detail?id=725028 and is not needed for 59 yet. NOTRY=true NOPRESUBMIT=true Original issue's description: > [Cast,Android] Replace custom MediaController with android.widget.MediaController. > > BUG=722688 > TEST=manual (cast a video from Chrome and tap on the notification, test the fullscreen controls) > > Review-Url: https://codereview.chromium.org/2888653002 > Cr-Original-Commit-Position: refs/heads/master@{#472583} > Review-Url: https://codereview.chromium.org/2888273002 . > Cr-Commit-Position: refs/branch-heads/3071@{#613} > Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/eda6f4cf4ff69bea98350b37c43609fae020175c TBR= # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=722688 Review-Url: https://codereview.chromium.org/2899033002 Cr-Commit-Position: refs/branch-heads/3071@{#673} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/91754cf24203d703142138a81431cc178150014c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+852 lines, -127 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/expanded_cast_controller.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java View 13 chunks +95 lines, -125 lines 0 comments Download
A third_party/android_media/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/android_media/LICENSE View 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/android_media/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/android_media/README.chromium View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/android_media/java/res/layout/media_controller.xml View 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/android_media/java/res/values/colors.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/android_media/java/src/org/chromium/third_party/android/media/MediaController.java View 1 chunk +386 lines, -0 lines 0 comments Download
M tools/android/eclipse/.classpath View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
whywhat
Created Revert of [Cast,Android] Replace custom MediaController with android.widget.MediaController.
3 years, 7 months ago (2017-05-23 15:51:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899033002/1
3 years, 7 months ago (2017-05-23 15:52:26 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 7 months ago (2017-05-23 15:52:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899033002/1
3 years, 7 months ago (2017-05-23 17:52:01 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:53:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91754cf24203d703142138a81431...

Powered by Google App Engine
This is Rietveld 408576698