Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2888273002: [Cast,Android] Replace custom MediaController with android.widget.MediaController. (Closed)

Created:
3 years, 7 months ago by whywhat
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Cast,Android] Replace custom MediaController with android.widget.MediaController. BUG=722688 TEST=manual (cast a video from Chrome and tap on the notification, test the fullscreen controls) Review-Url: https://codereview.chromium.org/2888653002 Cr-Original-Commit-Position: refs/heads/master@{#472583} Review-Url: https://codereview.chromium.org/2888273002 . Cr-Commit-Position: refs/branch-heads/3071@{#613} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/eda6f4cf4ff69bea98350b37c43609fae020175c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -836 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/res/layout/expanded_cast_controller.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/ExpandedControllerActivity.java View 12 chunks +109 lines, -79 lines 0 comments Download
D third_party/android_media/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/android_media/LICENSE View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/android_media/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/android_media/README.chromium View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/android_media/java/res/layout/media_controller.xml View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/android_media/java/res/values/colors.xml View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/android_media/java/src/org/chromium/third_party/android/media/MediaController.java View 1 chunk +0 lines, -386 lines 0 comments Download
M tools/android/eclipse/.classpath View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
whywhat
Committed patchset #1 (id:1) manually as eda6f4cf4ff69bea98350b37c43609fae020175c.
3 years, 7 months ago (2017-05-18 01:31:38 UTC) #2
whywhat
3 years, 7 months ago (2017-05-23 15:51:53 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2899033002/ by avayvod@chromium.org.

The reason for reverting is: Caused
https://bugs.chromium.org/p/chromium/issues/detail?id=725028 and is not needed
for 59 yet..

Powered by Google App Engine
This is Rietveld 408576698