Fix missing library for crasphad_handler in Mac component build

Fix missing library for crasphad_handler in Mac component build

BUG=687407
Review-Url: https://codereview.chromium.org/2898203003
Cr-Commit-Position: refs/heads/master@{#474568}
Committed: https://chromium.googlesource.com/chromium/src/+/6c53ef4b54e0d30bc381eb9b0cf531ae78dc6525

[dvallet, 2017-05-24 05:16:08]

dvallet@chromium.org changed reviewers:
+ dpranke@chromium.org, skyostil@chromium.org

[dvallet, 2017-05-24 05:16:09]

PTAL, this is a solution to the problem described in
https://codereview.chromium.org/2841443002#msg26

[dvallet, 2017-05-24 05:16:20]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 05:16:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 07:06:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 07:06:21]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-05-24 16:31:48]

lgtm.

https://codereview.chromium.org/2898203003/diff/1/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2898203003/diff/1/headless/BUILD.gn#newcode536
headless/BUILD.gn:536: data += [ "$root_out_dir/Helpers/libbase.dylib" ]
I think this is probably better written as

    data_deps = [ ":copy_mac_helpers" ]

[Sami, 2017-05-24 17:34:16]

lgtm with Dirk's comment.

[dvallet, 2017-05-25 00:23:03]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-05-25 00:23:04]

https://codereview.chromium.org/2898203003/diff/1/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2898203003/diff/1/headless/BUILD.gn#newcode536
headless/BUILD.gn:536: data += [ "$root_out_dir/Helpers/libbase.dylib" ]
On 2017/05/24 at 16:31:48, Dirk Pranke (slow) wrote:
> I think this is probably better written as
> 
>     data_deps = [ ":copy_mac_helpers" ]

Done, thanks for the tip!

[dvallet, 2017-05-25 00:23:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2898203003/#ps20001
(title: "changed to data_deps")

[commit-bot: I haz the power, 2017-05-25 00:23:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 04:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:12:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dvallet, 2017-05-25 04:13:19]

The CQ bit was checked by dvallet@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:13:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 05:41:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495685599594460,
"parent_rev": "2ee241f419323d7dd924c8bf4b4506189b0319ab", "commit_rev":
"6c53ef4b54e0d30bc381eb9b0cf531ae78dc6525"}

[commit-bot: I haz the power, 2017-05-25 05:41:14]

Description was changed from

==========
Fix missing library for crasphad_handler in Mac component build

BUG=687407
==========

to

==========
Fix missing library for crasphad_handler in Mac component build

BUG=687407

Review-Url: https://codereview.chromium.org/2898203003
Cr-Commit-Position: refs/heads/master@{#474568}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c53ef4b54e0d30bc381eb9b0cf5...
==========

[commit-bot: I haz the power, 2017-05-25 05:41:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6c53ef4b54e0d30bc381eb9b0cf5...