|
|
DescriptionInclude headless tests in all swarm version for Windows, since it's been enabled
Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002)
BUG=686608
Review-Url: https://codereview.chromium.org/2841443002
Cr-Original-Commit-Position: refs/heads/master@{#472023}
Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3e41be71c3d2c
Review-Url: https://codereview.chromium.org/2841443002
Cr-Commit-Position: refs/heads/master@{#474937}
Committed: https://chromium.googlesource.com/chromium/src/+/3d53e52c1841c3f52f037ae57cf83ebb7ef13ecb
Patch Set 1 #
Total comments: 1
Patch Set 2 : Updated upstream #
Messages
Total messages: 37 (22 generated)
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dvallet@chromium.org changed reviewers: + dpranke@chromium.org, skyostil@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm, thanks for taking care of this!
lgtm w/ comment. https://codereview.chromium.org/2841443002/diff/1/testing/buildbot/chromium.m... File testing/buildbot/chromium.mac.json (right): https://codereview.chromium.org/2841443002/diff/1/testing/buildbot/chromium.m... testing/buildbot/chromium.mac.json:29: "Mac10.10 Tests": { Do you need to add the tests to Mac10.10 Tests as well?
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dvallet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2841443002/#ps20001 (title: "Updated upstream")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494908340435160, "parent_rev": "7bbfe9f60233e5bed915af951a960210c9c94cc2", "commit_rev": "386add8ced87b5b0c91d4f91b0f3e41be71c3d2c"}
Message was sent while issue was closed.
Description was changed from ========== Include headless tests in all swarm version for Windows, since it's been enabled Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002) BUG=686608 ========== to ========== Include headless tests in all swarm version for Windows, since it's been enabled Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002) BUG=686608 Review-Url: https://codereview.chromium.org/2841443002 Cr-Commit-Position: refs/heads/master@{#472023} Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2887663002/ by kolos@chromium.org. The reason for reverting is: This CL broke some Mac tests https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2... https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2... FindIt report: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.c....
@dpranke: Could you help us out with the Mac build failure? I looked into it and it seems like it's getting a library missing error: CrashReporterTest.GenerateMinidump dyld: Library not loaded: @rpath/libbase.dylib Referenced from: /b/swarm_slave/w/ir/out/Debug/Helpers/crashpad_handler Reason: image not found I found this related bug: https://bugs.chromium.org/p/chromium/issues/detail?id=551886 But it doesn't seem to be the actual solution now
Can you point me at a log? I can't see what failure you're talking about ...
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495773393244740, "parent_rev": "c1148176d6794fff0fd8dba2b9f7ed71ec52fed8", "commit_rev": "3d53e52c1841c3f52f037ae57cf83ebb7ef13ecb"}
Message was sent while issue was closed.
Description was changed from ========== Include headless tests in all swarm version for Windows, since it's been enabled Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002) BUG=686608 Review-Url: https://codereview.chromium.org/2841443002 Cr-Commit-Position: refs/heads/master@{#472023} Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3... ========== to ========== Include headless tests in all swarm version for Windows, since it's been enabled Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002) BUG=686608 Review-Url: https://codereview.chromium.org/2841443002 Cr-Original-Commit-Position: refs/heads/master@{#472023} Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3... Review-Url: https://codereview.chromium.org/2841443002 Cr-Commit-Position: refs/heads/master@{#474937} Committed: https://chromium.googlesource.com/chromium/src/+/3d53e52c1841c3f52f037ae57cf8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3d53e52c1841c3f52f037ae57cf8... |