Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2841443002: Include headless tests in all swarm version for Windows, since it's been enabled (Closed)

Created:
3 years, 8 months ago by dvallet
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Include headless tests in all swarm version for Windows, since it's been enabled Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002) BUG=686608 Review-Url: https://codereview.chromium.org/2841443002 Cr-Original-Commit-Position: refs/heads/master@{#472023} Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3e41be71c3d2c Review-Url: https://codereview.chromium.org/2841443002 Cr-Commit-Position: refs/heads/master@{#474937} Committed: https://chromium.googlesource.com/chromium/src/+/3d53e52c1841c3f52f037ae57cf83ebb7ef13ecb

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 1 3 chunks +66 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 4 chunks +88 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (22 generated)
Sami
lgtm, thanks for taking care of this!
3 years, 8 months ago (2017-04-24 19:01:47 UTC) #6
Dirk Pranke
lgtm w/ comment. https://codereview.chromium.org/2841443002/diff/1/testing/buildbot/chromium.mac.json File testing/buildbot/chromium.mac.json (right): https://codereview.chromium.org/2841443002/diff/1/testing/buildbot/chromium.mac.json#newcode29 testing/buildbot/chromium.mac.json:29: "Mac10.10 Tests": { Do you need ...
3 years, 8 months ago (2017-04-24 20:57:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841443002/20001
3 years, 7 months ago (2017-05-16 01:14:56 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/297313)
3 years, 7 months ago (2017-05-16 02:09:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841443002/20001
3 years, 7 months ago (2017-05-16 02:55:15 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455389)
3 years, 7 months ago (2017-05-16 04:14:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841443002/20001
3 years, 7 months ago (2017-05-16 04:19:27 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3e41be71c3d2c
3 years, 7 months ago (2017-05-16 05:51:29 UTC) #25
kolos1
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2887663002/ by kolos@chromium.org. ...
3 years, 7 months ago (2017-05-16 08:22:49 UTC) #26
dvallet
@dpranke: Could you help us out with the Mac build failure? I looked into it ...
3 years, 7 months ago (2017-05-16 23:54:58 UTC) #27
Dirk Pranke
Can you point me at a log? I can't see what failure you're talking about ...
3 years, 7 months ago (2017-05-23 22:35:46 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841443002/20001
3 years, 7 months ago (2017-05-25 23:15:29 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/303862)
3 years, 7 months ago (2017-05-26 04:15:07 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841443002/20001
3 years, 7 months ago (2017-05-26 04:37:23 UTC) #34
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 06:16:33 UTC) #37
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d53e52c1841c3f52f037ae57cf8...

Powered by Google App Engine
This is Rietveld 408576698