Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: headless/BUILD.gn

Issue 2898203003: Fix missing library for crasphad_handler in Mac component build (Closed)
Patch Set: changed to data_deps Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/BUILD.gn
diff --git a/headless/BUILD.gn b/headless/BUILD.gn
index c5de06f92ad9688cce9ca7c3b088d4a1181eb447..92f2f6b23694d31b8bbaf574dfbb675793170a5e 100644
--- a/headless/BUILD.gn
+++ b/headless/BUILD.gn
@@ -489,7 +489,12 @@ if (is_mac) {
"$root_out_dir/crashpad_handler",
]
+ if (is_component_build) {
+ sources += [ "$root_out_dir/libbase.dylib" ]
+ }
+
deps = [
+ "//base",
"//third_party/crashpad/crashpad/handler:crashpad_handler",
]
@@ -528,7 +533,7 @@ test("headless_browsertests") {
]
if (is_mac) {
- data += [ "$root_out_dir/Helpers/crashpad_handler" ]
+ data_deps = [ ":mac_helpers" ]
}
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698