Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2897993003: chromeos: converts WindowResizer to aura::Window (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
msw, reveman
CC:
chromium-reviews, dcheng, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: converts WindowResizer to aura::Window BUG=722553 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2897993003 Cr-Commit-Position: refs/heads/master@{#473682} Committed: https://chromium.googlesource.com/chromium/src/+/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 14

Patch Set 3 : feedback #

Patch Set 4 : remove include from exo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -249 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/default_state.cc View 7 chunks +15 lines, -17 lines 0 comments Download
M ash/wm/default_window_resizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 8 chunks +16 lines, -21 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer.h View 3 chunks +7 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 2 6 chunks +49 lines, -43 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/window_positioning_utils.h View 2 chunks +6 lines, -2 lines 0 comments Download
M ash/wm/window_positioning_utils.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M ash/wm/window_resizer.h View 3 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/window_resizer.cc View 1 2 8 chunks +35 lines, -12 lines 0 comments Download
M ash/wm/wm_toplevel_window_event_handler.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 2 21 chunks +77 lines, -67 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm_window.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm_window.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M components/exo/shell_surface.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
sky
3 years, 7 months ago (2017-05-22 18:01:59 UTC) #1
msw
lgtm with nits and qs https://codereview.chromium.org/2897993003/diff/20001/ash/wm/default_state.cc File ash/wm/default_state.cc (left): https://codereview.chromium.org/2897993003/diff/20001/ash/wm/default_state.cc#oldcode667 ash/wm/default_state.cc:667: window->SetPreMinimizedShowState(ToWindowShowState(previous_state_type)); optional nit: you ...
3 years, 7 months ago (2017-05-22 19:26:12 UTC) #6
sky
https://codereview.chromium.org/2897993003/diff/20001/ash/wm/default_state.cc File ash/wm/default_state.cc (left): https://codereview.chromium.org/2897993003/diff/20001/ash/wm/default_state.cc#oldcode667 ash/wm/default_state.cc:667: window->SetPreMinimizedShowState(ToWindowShowState(previous_state_type)); On 2017/05/22 19:26:11, msw wrote: > optional nit: ...
3 years, 7 months ago (2017-05-22 19:50:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897993003/40001
3 years, 7 months ago (2017-05-22 19:51:45 UTC) #10
sky
+reveman for exo
3 years, 7 months ago (2017-05-22 20:07:22 UTC) #12
reveman
lgtm
3 years, 7 months ago (2017-05-22 20:14:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897993003/60001
3 years, 7 months ago (2017-05-22 20:32:28 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 20:45:53 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a5e9a12879fd2dd7d9ce4e389c5d...

Powered by Google App Engine
This is Rietveld 408576698