chromeos: makes it possible for windows to outlive WindowTreeClient

chromeos: makes it possible for windows to outlive WindowTreeClient

Because of shutdown ordering we need to make it so aura::Windows can
outlive WindowTreeClient. WindowTreeClient is wired in by way of every
Window having a WindowPort. For mus the WindowPort is a WindowPortMus,
which has a reference to the WindowTreeClient. Rather then having a
slew of null checks I went with making ~WindowTreeClient reset the
WindowPorts to a no-op WindowPort during shutdown.

BUG=723825
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2897663002
Cr-Commit-Position: refs/heads/master@{#473274}
Committed: https://chromium.googlesource.com/chromium/src/+/2a454ebdc53801c9241e109db01c329c7b514770

[sky, 2017-05-19 14:57:49]

https://codereview.chromium.org/2897663002/diff/1/ui/aura/BUILD.gn
File ui/aura/BUILD.gn (right):

https://codereview.chromium.org/2897663002/diff/1/ui/aura/BUILD.gn#newcode9
ui/aura/BUILD.gn:9: public = [
This change is so that I can make it such that trying to include
window_port_for_shutdown.h anywhere outside of this code results in a gn check
failure.

[sky, 2017-05-19 14:57:56]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 14:58:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 16:08:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Elliot Glaysher, 2017-05-19 18:06:50]

i consider this unfortunate. both making a magic window port for shutdown and
making every call check for null are bad options.

lgtm.

[sky, 2017-05-19 18:08:22]

Agreed.

On Fri, May 19, 2017 at 11:06 AM, <erg@chromium.org> wrote:

> i consider this unfortunate. both making a magic window port for shutdown
> and
> making every call check for null are bad options.
>
> lgtm.
>
> https://codereview.chromium.org/2897663002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2017-05-19 18:09:01]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:09:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:26:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495217341384160,
"parent_rev": "dca47e28ab2e0f43b8b44874b3905676a3d961ce", "commit_rev":
"2a454ebdc53801c9241e109db01c329c7b514770"}

[commit-bot: I haz the power, 2017-05-19 19:26:26]

Description was changed from

==========
chromeos: makes it possible for windows to outlive WindowTreeClient

Because of shutdown ordering we need to make it so aura::Windows can
outlive WindowTreeClient. WindowTreeClient is wired in by way of every
Window having a WindowPort. For mus the WindowPort is a WindowPortMus,
which has a reference to the WindowTreeClient. Rather then having a
slew of null checks I went with making ~WindowTreeClient reset the
WindowPorts to a no-op WindowPort during shutdown.

BUG=723825
TEST=covered by tests
R=erg@chromium.org
==========

to

==========
chromeos: makes it possible for windows to outlive WindowTreeClient

Because of shutdown ordering we need to make it so aura::Windows can
outlive WindowTreeClient. WindowTreeClient is wired in by way of every
Window having a WindowPort. For mus the WindowPort is a WindowPortMus,
which has a reference to the WindowTreeClient. Rather then having a
slew of null checks I went with making ~WindowTreeClient reset the
WindowPorts to a no-op WindowPort during shutdown.

BUG=723825
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2897663002
Cr-Commit-Position: refs/heads/master@{#473274}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a454ebdc53801c9241e109db01c...
==========

[commit-bot: I haz the power, 2017-05-19 19:26:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a454ebdc53801c9241e109db01c...