Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2897663002: chromeos: makes it possible for windows to outlive WindowTreeClient (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by sky
Modified:
4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: makes it possible for windows to outlive WindowTreeClient Because of shutdown ordering we need to make it so aura::Windows can outlive WindowTreeClient. WindowTreeClient is wired in by way of every Window having a WindowPort. For mus the WindowPort is a WindowPortMus, which has a reference to the WindowTreeClient. Rather then having a slew of null checks I went with making ~WindowTreeClient reset the WindowPorts to a no-op WindowPort during shutdown. BUG=723825 TEST=covered by tests R=erg@chromium.org Review-Url: https://codereview.chromium.org/2897663002 Cr-Commit-Position: refs/heads/master@{#473274} Committed: https://chromium.googlesource.com/chromium/src/+/2a454ebdc53801c9241e109db01c329c7b514770

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -83 lines) Patch
M ash/shell_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/aura/BUILD.gn View 2 chunks +65 lines, -67 lines 0 comments Download
M ui/aura/env.h View 4 chunks +9 lines, -1 line 0 comments Download
M ui/aura/env.cc View 4 chunks +16 lines, -1 line 0 comments Download
M ui/aura/mus/focus_synchronizer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 4 chunks +17 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/aura/test/env_test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window.h View 3 chunks +6 lines, -1 line 0 comments Download
A ui/aura/window_port_for_shutdown.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ui/aura/window_port_for_shutdown.cc View 1 chunk +63 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (7 generated)
sky
https://codereview.chromium.org/2897663002/diff/1/ui/aura/BUILD.gn File ui/aura/BUILD.gn (right): https://codereview.chromium.org/2897663002/diff/1/ui/aura/BUILD.gn#newcode9 ui/aura/BUILD.gn:9: public = [ This change is so that I ...
4 months ago (2017-05-19 14:57:49 UTC) #1
Elliot Glaysher
i consider this unfortunate. both making a magic window port for shutdown and making every ...
4 months ago (2017-05-19 18:06:50 UTC) #6
sky
Agreed. On Fri, May 19, 2017 at 11:06 AM, <erg@chromium.org> wrote: > i consider this ...
4 months ago (2017-05-19 18:08:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897663002/20001
4 months ago (2017-05-19 18:09:57 UTC) #9
commit-bot: I haz the power
4 months ago (2017-05-19 19:26:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a454ebdc53801c9241e109db01c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b