Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: ash/shell_unittest.cc

Issue 2897663002: chromeos: makes it possible for windows to outlive WindowTreeClient (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/aura/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell_unittest.cc
diff --git a/ash/shell_unittest.cc b/ash/shell_unittest.cc
index c461f6617c4664f9d9ab4f7e0bf7d57c6fd0a537..e1c99c91f329ba287476947d11dfd0e03ce71984 100644
--- a/ash/shell_unittest.cc
+++ b/ash/shell_unittest.cc
@@ -506,13 +506,6 @@ class ShellTest2 : public test::AshTestBase {
};
TEST_F(ShellTest2, DontCrashWhenWindowDeleted) {
- // TODO: delete this test when conversion to mash is done. This test isn't
- // applicable to mash as all windows must be destroyed before ash, that isn't
- // the case with classic-ash where embedders can separately create
- // aura::Windows.
- if (Shell::GetAshConfig() == Config::MASH)
- return;
-
window_.reset(new aura::Window(NULL));
window_->Init(ui::LAYER_NOT_DRAWN);
}
« no previous file with comments | « no previous file | ui/aura/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698