Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2897573003: Reland - [Autofill] Enable Autofill UKM by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 3 hours ago by sebsg
Modified:
4 days, 19 hours ago
Reviewers:
csashi, Mathieu
CC:
chromium-reviews, rouslan+payments_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland - [Autofill] Enable Autofill UKM by default. Initial CL: https://codereview.chromium.org/2874413004/ Was reverted because it triggered a DCHECK in the UKMFormLogger. csashi@ fixed this issue now (see crbug.com/722947). BUG=718014 Review-Url: https://codereview.chromium.org/2897573003 Cr-Commit-Position: refs/heads/master@{#473362} Committed: https://chromium.googlesource.com/chromium/src/+/f9df7482eb3b4ae01667614195c8878c74b9ae6a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -104 lines) Patch
M components/autofill/core/browser/autofill_experiments.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 28 chunks +6 lines, -30 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 23 chunks +0 lines, -54 lines 0 comments Download
M components/payments/core/journey_logger.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/payments/core/journey_logger_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (9 generated)
sebsg
Hi, PTAL?
5 days, 3 hours ago (2017-05-19 14:36:58 UTC) #3
csashi
lgtm
5 days, 1 hour ago (2017-05-19 16:09:47 UTC) #5
Mathieu
lgtm
4 days, 20 hours ago (2017-05-19 21:09:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897573003/20001
4 days, 20 hours ago (2017-05-19 21:11:39 UTC) #11
commit-bot: I haz the power
4 days, 19 hours ago (2017-05-19 22:22:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f9df7482eb3b4ae01667614195c8...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06