Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 2897573003: Reland - [Autofill] Enable Autofill UKM by default. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.cc
diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc
index 8075cff3757823656dfd8964a5d135e5a4e29ce0..3385d682afa746d6eeda4f2e2c0c4b805f9c7468 100644
--- a/components/autofill/core/browser/autofill_metrics.cc
+++ b/components/autofill/core/browser/autofill_metrics.cc
@@ -793,8 +793,7 @@ bool AutofillMetrics::LogUkm(
const GURL& url,
const std::string& ukm_entry_name,
const std::vector<std::pair<const char*, int>>& metrics) {
- if (!IsUkmLoggingEnabled() || !ukm_service || !url.is_valid() ||
- metrics.empty()) {
+ if (!ukm_service || !url.is_valid() || metrics.empty()) {
return false;
}
@@ -1035,7 +1034,7 @@ AutofillMetrics::FormInteractionsUkmLogger::FormInteractionsUkmLogger(
void AutofillMetrics::FormInteractionsUkmLogger::OnFormsParsed(
const GURL& url) {
- if (!IsUkmLoggingEnabled() || ukm_service_ == nullptr)
+ if (ukm_service_ == nullptr)
return;
url_ = url;
@@ -1158,7 +1157,7 @@ void AutofillMetrics::FormInteractionsUkmLogger::UpdateSourceURL(
}
bool AutofillMetrics::FormInteractionsUkmLogger::CanLog() const {
- return IsUkmLoggingEnabled() && ukm_service_ && url_.is_valid();
+ return ukm_service_ && url_.is_valid();
}
int64_t

Powered by Google App Engine
This is Rietveld 408576698