Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2874413004: [Autofill] Enable Autofill UKM by default. (Closed)

Created:
3 years, 7 months ago by sebsg
Modified:
3 years, 7 months ago
Reviewers:
csashi, Mathieu
CC:
chromium-reviews, rouslan+payments_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sebsg+paymentswatch_chromium.org, csashi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Enable Autofill UKM by default. BUG=718014 Review-Url: https://codereview.chromium.org/2874413004 Cr-Commit-Position: refs/heads/master@{#472094} Committed: https://chromium.googlesource.com/chromium/src/+/06fc093968064421daf828caf503ef5fafb07cba

Patch Set 1 #

Patch Set 2 : Fixed all but one test #

Total comments: 2

Patch Set 3 : Rebase and change function name #

Total comments: 4

Patch Set 4 : Removed unnecessary includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -104 lines) Patch
M components/autofill/core/browser/autofill_experiments.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 28 chunks +6 lines, -30 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 2 23 chunks +0 lines, -54 lines 0 comments Download
M components/payments/core/journey_logger.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M components/payments/core/journey_logger_unittest.cc View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
csashi
lgtm https://codereview.chromium.org/2874413004/diff/20001/components/autofill/core/browser/autofill_manager_unittest.cc File components/autofill/core/browser/autofill_manager_unittest.cc (left): https://codereview.chromium.org/2874413004/diff/20001/components/autofill/core/browser/autofill_manager_unittest.cc#oldcode1077 components/autofill/core/browser/autofill_manager_unittest.cc:1077: void EnableAutofillUpstreamRequestCvcIfMissingExperimentAndUkmLogging() { Update function name?
3 years, 7 months ago (2017-05-15 23:46:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874413004/40001
3 years, 7 months ago (2017-05-16 01:04:51 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 01:04:54 UTC) #8
sebsg
Hi Math, PTAL? https://codereview.chromium.org/2874413004/diff/20001/components/autofill/core/browser/autofill_manager_unittest.cc File components/autofill/core/browser/autofill_manager_unittest.cc (left): https://codereview.chromium.org/2874413004/diff/20001/components/autofill/core/browser/autofill_manager_unittest.cc#oldcode1077 components/autofill/core/browser/autofill_manager_unittest.cc:1077: void EnableAutofillUpstreamRequestCvcIfMissingExperimentAndUkmLogging() { On 2017/05/15 23:46:33, ...
3 years, 7 months ago (2017-05-16 01:06:25 UTC) #10
Mathieu
lgtm with comments https://codereview.chromium.org/2874413004/diff/40001/components/payments/core/journey_logger.cc File components/payments/core/journey_logger.cc (right): https://codereview.chromium.org/2874413004/diff/40001/components/payments/core/journey_logger.cc#newcode11 components/payments/core/journey_logger.cc:11: #include "components/autofill/core/browser/autofill_experiments.h" need? https://codereview.chromium.org/2874413004/diff/40001/components/payments/core/journey_logger_unittest.cc File components/payments/core/journey_logger_unittest.cc ...
3 years, 7 months ago (2017-05-16 01:20:53 UTC) #11
sebsg
Thanks, sending to CQ https://codereview.chromium.org/2874413004/diff/40001/components/payments/core/journey_logger.cc File components/payments/core/journey_logger.cc (right): https://codereview.chromium.org/2874413004/diff/40001/components/payments/core/journey_logger.cc#newcode11 components/payments/core/journey_logger.cc:11: #include "components/autofill/core/browser/autofill_experiments.h" On 2017/05/16 01:20:53, ...
3 years, 7 months ago (2017-05-16 12:13:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874413004/60001
3 years, 7 months ago (2017-05-16 12:13:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/371692)
3 years, 7 months ago (2017-05-16 13:11:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874413004/60001
3 years, 7 months ago (2017-05-16 13:19:59 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/06fc093968064421daf828caf503ef5fafb07cba
3 years, 7 months ago (2017-05-16 14:08:05 UTC) #22
dmazzoni
3 years, 7 months ago (2017-05-16 18:46:57 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2888633002/ by dmazzoni@chromium.org.

The reason for reverting is: Failing consistently on
chromium.memory/Linux ASan LSan Tests (1)

See crbug.com/722947
.

Powered by Google App Engine
This is Rietveld 408576698