Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2897493002: Rename DMC::SetMarkersActive() to SetTextMatchMarkersActive() (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DMC::SetMarkersActive() to SetTextMatchMarkersActive() Rename DocumentMarkerController::SetMarkersActive() to SetTextMatchMarkersActive(). The current name of this method is confusing since only TextMatch markers can be active or inactive. I'm also fixing a PossiblyHasMarkers() check to be more specific (checking for TextMatch markers instead of all types). BUG=707867 Review-Url: https://codereview.chromium.org/2897493002 Cr-Commit-Position: refs/heads/master@{#473099} Committed: https://chromium.googlesource.com/chromium/src/+/97cf10ffd89f897b67f489c4b072886e186c9944

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert change to rename whitelist file #

Messages

Total messages: 14 (8 generated)
rlanday
3 years, 7 months ago (2017-05-18 22:27:01 UTC) #4
Xiaocheng
lgtm +dcheng for owner's review
3 years, 7 months ago (2017-05-19 00:05:27 UTC) #6
dcheng
LGTM with a nit https://codereview.chromium.org/2897493002/diff/1/tools/blink_rename_merge_helper/data/idl_blocklist.txt File tools/blink_rename_merge_helper/data/idl_blocklist.txt (right): https://codereview.chromium.org/2897493002/diff/1/tools/blink_rename_merge_helper/data/idl_blocklist.txt#newcode3250 tools/blink_rename_merge_helper/data/idl_blocklist.txt:3250: Internals:::setTextMatchMarkersActive:::4 Nit: please revert the ...
3 years, 7 months ago (2017-05-19 02:33:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897493002/20001
3 years, 7 months ago (2017-05-19 03:45:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/97cf10ffd89f897b67f489c4b072886e186c9944
3 years, 7 months ago (2017-05-19 05:40:10 UTC) #13
yosin_UTC9
3 years, 7 months ago (2017-05-19 05:49:14 UTC) #14
Message was sent while issue was closed.
lgtm
Oops, late response..

Powered by Google App Engine
This is Rietveld 408576698