third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp - Issue 2897493002: Rename DMC::SetMarkersActive() to SetTextMatchMarkersActive()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2897493002: Rename DMC::SetMarkersActive() to SetTextMatchMarkersActive() (Closed)

Patch Set: Revert change to rename whitelist file Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

index 0e23593766962c11d7b8bb844db704ffee0dff20..d08737792b7fe9211a0d2e7a604572bd9e0bd557 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

@@ -228,13 +228,13 @@ TEST_F(DocumentMarkerControllerTest, SetMarkerActiveTest) {

Position end_b_element = ToPositionInDOMTree(ephemeral_range.EndPosition());

const EphemeralRange range(start_b_element, end_b_element);

// Try to make active a marker that doesn't exist.

- EXPECT_FALSE(MarkerController().SetMarkersActive(range, true));

+ EXPECT_FALSE(MarkerController().SetTextMatchMarkersActive(range, true));

// Add a marker and try it once more.

MarkerController().AddTextMatchMarker(range,

DocumentMarker::MatchStatus::kInactive);

EXPECT_EQ(1u, MarkerController().Markers().size());

- EXPECT_TRUE(MarkerController().SetMarkersActive(range, true));

+ EXPECT_TRUE(MarkerController().SetTextMatchMarkersActive(range, true));

}

TEST_F(DocumentMarkerControllerTest, RemoveStartOfMarker) {