Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2897493002: Rename DMC::SetMarkersActive() to SetTextMatchMarkersActive() (Closed)
Patch Set: Revert change to rename whitelist file Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
index e6e67c732f3df129031ba0821c0804b295cb8734..fec3216382fb0e3e66c9e400dcd2f4e6e76014b9 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
@@ -608,9 +608,10 @@ void DocumentMarkerController::RepaintMarkers(
}
}
-bool DocumentMarkerController::SetMarkersActive(const EphemeralRange& range,
- bool active) {
- if (!PossiblyHasMarkers(DocumentMarker::AllMarkers()))
+bool DocumentMarkerController::SetTextMatchMarkersActive(
+ const EphemeralRange& range,
+ bool active) {
+ if (!PossiblyHasMarkers(DocumentMarker::kTextMatch))
return false;
DCHECK(!markers_.IsEmpty());
@@ -629,15 +630,16 @@ bool DocumentMarkerController::SetMarkersActive(const EphemeralRange& range,
for (Node& node : range.Nodes()) {
int start_offset = node == start_container ? container_start_offset : 0;
int end_offset = node == end_container ? container_end_offset : INT_MAX;
- marker_found |= SetMarkersActive(&node, start_offset, end_offset, active);
+ marker_found |=
+ SetTextMatchMarkersActive(&node, start_offset, end_offset, active);
}
return marker_found;
}
-bool DocumentMarkerController::SetMarkersActive(Node* node,
- unsigned start_offset,
- unsigned end_offset,
- bool active) {
+bool DocumentMarkerController::SetTextMatchMarkersActive(Node* node,
+ unsigned start_offset,
+ unsigned end_offset,
+ bool active) {
MarkerLists* markers = markers_.at(node);
if (!markers)
return false;

Powered by Google App Engine
This is Rietveld 408576698