Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2897433002: X509CertificateBytes: Allow invalid serial numbers for now. (Closed)

Created:
3 years, 7 months ago by mattm
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

X509CertificateBytes: Allow invalid serial numbers for now. BUG=721778 Review-Url: https://codereview.chromium.org/2881023003 Cr-Original-Commit-Position: refs/heads/master@{#472040} Review-Url: https://codereview.chromium.org/2897433002 . Cr-Commit-Position: refs/branch-heads/3071@{#619} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/3ba70668b65f4c0ce92b7f50602289cc018b24d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -185 lines) Patch
M net/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M net/cert/internal/parse_certificate_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M net/cert/internal/parsed_certificate_unittest.cc View 17 chunks +94 lines, -25 lines 0 comments Download
M net/cert/x509_certificate_bytes.cc View 5 chunks +14 lines, -4 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 chunk +64 lines, -16 lines 0 comments Download
A net/data/parse_certificate_unittest/serial_37_bytes.pem View 1 chunk +13 lines, -0 lines 0 comments Download
A net/data/parse_certificate_unittest/serial_negative.pem View 1 chunk +12 lines, -0 lines 0 comments Download
A net/data/parse_certificate_unittest/serial_zero_padded.pem View 1 chunk +13 lines, -0 lines 0 comments Download
A net/data/parse_certificate_unittest/serial_zero_padded_21_bytes.pem View 1 chunk +14 lines, -0 lines 0 comments Download
D net/data/parse_certificate_unittest/tbs_negative_serial_number.pem View 1 chunk +0 lines, -68 lines 0 comments Download
D net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem View 1 chunk +0 lines, -24 lines 0 comments Download
D net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem View 1 chunk +0 lines, -24 lines 0 comments Download
M net/data/parse_certificate_unittest/v3_certificate_template.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mattm
3 years, 7 months ago (2017-05-18 19:27:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ba70668b65f4c0ce92b7f50602289cc018b24d6.

Powered by Google App Engine
This is Rietveld 408576698