Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(407)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: net/data/parse_certificate_unittest/serial_negative.pem
Issue
2897433002
:
X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
Patch Set:
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
net/BUILD.gn
net/cert/internal/parse_certificate_unittest.cc
net/cert/internal/parsed_certificate_unittest.cc
net/cert/x509_certificate_bytes.cc
net/cert/x509_certificate_unittest.cc
net/data/parse_certificate_unittest/serial_37_bytes.pem
net/data/parse_certificate_unittest/serial_negative.pem
net/data/parse_certificate_unittest/serial_zero_padded.pem
net/data/parse_certificate_unittest/serial_zero_padded_21_bytes.pem
net/data/parse_certificate_unittest/tbs_negative_serial_number.pem
net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem
net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem
net/data/parse_certificate_unittest/v3_certificate_template.txt
View unified diff
|
Download patch
« no previous file with comments
|
« net/data/parse_certificate_unittest/serial_37_bytes.pem
('k') |
net/data/parse_certificate_unittest/serial_zero_padded.pem »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
This cert has an invalid serial number which is negative.
2
3
The certificate data can be updated/regenerated with the
4
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py script.
5
6
#-----BEGIN SERIAL-----
7
INTEGER { `8001` }
8
#-----END SERIAL-----
9
10
-----BEGIN CERTIFICATE-----
11
MIICUTCCAbqgAwIBAgICgAEwDQYJKoZIhvcNAQEFBQAwRTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNv bWUtU3RhdGUxITAfBgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDAeFw0xNDA0MjMyMDUwNDBa Fw0xNzA0MjIyMDUwNDBaMEUxCzAJBgNVBAYTAkFVMRMwEQYDVQQIDApTb21lLVN0YXRlMSEwHwYDVQQK DBhJbnRlcm5ldCBXaWRnaXRzIFB0eSBMdGQwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANgryKYy 5GL/TfPQrVmLRae98Ue/CVh7Ir01rpclhpSggMC0H3aRZ0Yx0BCEtyIecCORcsjpbXk6hXeAD8SVFnXF SnFMyGM/o/JjnCpPmvrLwXFuKIUooCceZRyuB9Vbby1D7SuQsYyvJG2u6Rc6BcG/uByuZTsbWMLZrtaq Z4jxAgMBAAGjUDBOMB0GA1UdDgQWBBSLddWsywi+Dh9lt/pWvmynddqFrzAfBgNVHSMEGDAWgBSLddWs ywi+Dh9lt/pWvmynddqFrzAMBgNVHRMEBTADAQH/MA0GCSqGSIb3DQEBBQUAA4GBADvoeG2V1j1q9xMZ LBvCiK4iq/SNMvV8cWfPLdEcwsOH4um+iVzkNKtIkcI/la4rR54leGtPmhCkcv3P9wIMsAoIpFri5XR+ ER05YGrJH2nzLmMm3J7va3oK4VRXmKpykXgEfh+PZU0fCxKsnCQPhBQaVS0fu/CdCbIIXFkyZYAm
12
-----END CERTIFICATE-----
OLD
NEW
« no previous file with comments
|
« net/data/parse_certificate_unittest/serial_37_bytes.pem
('k') |
net/data/parse_certificate_unittest/serial_zero_padded.pem »
('j') |
no next file with comments »
Issue 2897433002: X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
Created 3 years, 7 months ago by mattm
Modified 3 years, 7 months ago
Reviewers:
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2897433002:
X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
