Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(7)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: net/data/parse_certificate_unittest/serial_zero_padded.pem
Issue
2897433002
:
X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
Patch Set:
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
net/BUILD.gn
net/cert/internal/parse_certificate_unittest.cc
net/cert/internal/parsed_certificate_unittest.cc
net/cert/x509_certificate_bytes.cc
net/cert/x509_certificate_unittest.cc
net/data/parse_certificate_unittest/serial_37_bytes.pem
net/data/parse_certificate_unittest/serial_negative.pem
net/data/parse_certificate_unittest/serial_zero_padded.pem
net/data/parse_certificate_unittest/serial_zero_padded_21_bytes.pem
net/data/parse_certificate_unittest/tbs_negative_serial_number.pem
net/data/parse_certificate_unittest/tbs_serial_number_21_octets_leading_0.pem
net/data/parse_certificate_unittest/tbs_serial_number_26_octets.pem
net/data/parse_certificate_unittest/v3_certificate_template.txt
View unified diff
|
Download patch
« no previous file with comments
|
« net/data/parse_certificate_unittest/serial_negative.pem
('k') |
net/data/parse_certificate_unittest/serial_zero_padded_21_bytes.pem »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
This cert has a valid serial number which has a preceding zero padding byte due
2
to the asn.1 encoding.
3
4
The certificate data can be updated/regenerated with the
5
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py script.
6
7
#-----BEGIN SERIAL-----
8
INTEGER { `008001` }
9
#-----END SERIAL-----
10
11
-----BEGIN CERTIFICATE-----
12
MIICUjCCAbugAwIBAgIDAIABMA0GCSqGSIb3DQEBBQUAMEUxCzAJBgNVBAYTAkFVMRMwEQYDVQQIDApT b21lLVN0YXRlMSEwHwYDVQQKDBhJbnRlcm5ldCBXaWRnaXRzIFB0eSBMdGQwHhcNMTQwNDIzMjA1MDQw WhcNMTcwNDIyMjA1MDQwWjBFMQswCQYDVQQGEwJBVTETMBEGA1UECAwKU29tZS1TdGF0ZTEhMB8GA1UE CgwYSW50ZXJuZXQgV2lkZ2l0cyBQdHkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDYK8im MuRi/03z0K1Zi0WnvfFHvwlYeyK9Na6XJYaUoIDAtB92kWdGMdAQhLciHnAjkXLI6W15OoV3gA/ElRZ1 xUpxTMhjP6PyY5wqT5r6y8FxbiiFKKAnHmUcrgfVW28tQ+0rkLGMryRtrukXOgXBv7gcrmU7G1jC2a7W qmeI8QIDAQABo1AwTjAdBgNVHQ4EFgQUi3XVrMsIvg4fZbf6Vr5sp3Xaha8wHwYDVR0jBBgwFoAUi3XV rMsIvg4fZbf6Vr5sp3Xaha8wDAYDVR0TBAUwAwEB/zANBgkqhkiG9w0BAQUFAAOBgQA76HhtldY9avcT GSwbwoiuIqv0jTL1fHFnzy3RHMLDh+Lpvolc5DSrSJHCP5WuK0eeJXhrT5oQpHL9z/cCDLAKCKRa4uV0 fhEdOWBqyR9p8y5jJtye72t6CuFUV5iqcpF4BH4fj2VNHwsSrJwkD4QUGlUtH7vwnQmyCFxZMmWAJg==
13
-----END CERTIFICATE-----
OLD
NEW
« no previous file with comments
|
« net/data/parse_certificate_unittest/serial_negative.pem
('k') |
net/data/parse_certificate_unittest/serial_zero_padded_21_bytes.pem »
('j') |
no next file with comments »
Issue 2897433002: X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
Created 3 years, 7 months ago by mattm
Modified 3 years, 7 months ago
Reviewers:
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2897433002:
X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
