Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2897233002:
Adds translate infobar impression in the old Translate UI on Android (Closed)
|
Created:
3 years, 7 months ago by ramyasharma Modified:
3 years, 7 months ago CC:
chromium-reviews, agrieve+watch_chromium.org, asvitkine+watch_chromium.org, dfalcantara+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdds translate infobar impression in the old Translate UI on Android
This is added so that we can compare the impressions in old UI and
the new one.
BUG=720231
Review-Url: https://codereview.chromium.org/2897233002
Cr-Commit-Position: refs/heads/master@{#474961}
Committed: https://chromium.googlesource.com/chromium/src/+/c378166dd1a360be0ccf9359631e5765dc544209
Patch Set 1 #
Total comments: 6
Patch Set 2 #
Total comments: 2
Patch Set 3 #
Messages
Total messages: 30 (21 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Adds translate infobar impression in the old Translate UI on Android BUG=720231 ========== to ========== Adds translate infobar impression in the old Translate UI on Android This is added so that we can compare the impressions in old UI and the new one. BUG=720231 ==========
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run
Patchset #1 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ramyasharma@chromium.org changed reviewers: + googleo@chromium.org, isherman@chromium.org, mdjones@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Metrics LGTM % nits: https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:76443: +<histogram name="Translate.InfobarImpression" enum="Boolean" units="views"> nit: Perhaps name this "InfobarShown" or "InfobarViewed"? https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:76443: +<histogram name="Translate.InfobarImpression" enum="Boolean" units="views"> nit: Units are not supported on enum histograms (arguably they should be, but we currently don't have support for them implemented.) https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:76443: +<histogram name="Translate.InfobarImpression" enum="Boolean" units="views"> enum: Please specify "BooleanHit"; or better yet, use a custom enum with a label like "Infobar shown".
Thanks Ilya. https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:76443: +<histogram name="Translate.InfobarImpression" enum="Boolean" units="views"> On 2017/05/25 22:24:48, Ilya Sherman wrote: > nit: Perhaps name this "InfobarShown" or "InfobarViewed"? Done. https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:76443: +<histogram name="Translate.InfobarImpression" enum="Boolean" units="views"> On 2017/05/25 22:24:48, Ilya Sherman wrote: > nit: Perhaps name this "InfobarShown" or "InfobarViewed"? Done. https://codereview.chromium.org/2897233002/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:76443: +<histogram name="Translate.InfobarImpression" enum="Boolean" units="views"> On 2017/05/25 22:24:48, Ilya Sherman wrote: > enum: Please specify "BooleanHit"; or better yet, use a custom enum with a label > like "Infobar shown". Done.
The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2897233002/diff/100001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java (right): https://codereview.chromium.org/2897233002/diff/100001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java:179: RecordHistogram.recordBooleanHistogram(INFOBAR_IMPRESSION_HISTOGRAM, true); Are you going to record all steps's impression or one visit impression. Because the logging above will record one visit's all steps. Eg. 1 page will be logged 2~4 times impressions. Not sure whether it's what you want.
The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run
Thanks Leo. https://codereview.chromium.org/2897233002/diff/100001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java (right): https://codereview.chromium.org/2897233002/diff/100001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java:179: RecordHistogram.recordBooleanHistogram(INFOBAR_IMPRESSION_HISTOGRAM, true); On 2017/05/26 00:37:17, Leo wrote: > Are you going to record all steps's impression or one visit impression. > > Because the logging above will record one visit's all steps. Eg. 1 page will be > logged 2~4 times impressions. > > Not sure whether it's what you want. Thanks Leo. Changed this according to our offline discussion. Now I am logging only in cases when its a new infobar at step1, or always is true and translating infobar is shown.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by ramyasharma@chromium.org
The CQ bit was checked by ramyasharma@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2897233002/#ps120001 (title: "")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495774532186400,
"parent_rev": "417a58a02148fdffd9b23940e9747214386ac60f", "commit_rev":
"c378166dd1a360be0ccf9359631e5765dc544209"}
Message was sent while issue was closed.
Description was changed from ========== Adds translate infobar impression in the old Translate UI on Android This is added so that we can compare the impressions in old UI and the new one. BUG=720231 ========== to ========== Adds translate infobar impression in the old Translate UI on Android This is added so that we can compare the impressions in old UI and the new one. BUG=720231 Review-Url: https://codereview.chromium.org/2897233002 Cr-Commit-Position: refs/heads/master@{#474961} Committed: https://chromium.googlesource.com/chromium/src/+/c378166dd1a360be0ccf9359631e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as https://chromium.googlesource.com/chromium/src/+/c378166dd1a360be0ccf9359631e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
