tools/metrics/histograms/histograms.xml - Issue 2897233002: Adds translate infobar impression in the old Translate UI on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2897233002: Adds translate infobar impression in the old Translate UI on Android (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 7de5ee9588f25c6f8f38940f6919a63cce2fdb85..71fc9cf9f1f2327514cc24f3acacfca25898a118 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -76440,6 +76440,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Translate.InfobarImpression" enum="Boolean" units="views">

Ilya Sherman 2017/05/25 22:24:48 enum: Please specify "BooleanHit"; or better yet,

Ilya Sherman 2017/05/25 22:24:48 nit: Perhaps name this "InfobarShown" or "InfobarV

Ilya Sherman 2017/05/25 22:24:48 nit: Units are not supported on enum histograms (a

ramyasharma 2017/05/26 00:17:42 Done.

+ <owner>ramyasharma@google.com</owner>

+ <summary>

+ The number of times the translate infobar was shown in the UI on Android.

+ Only true is recorded.

+ </summary>

+</histogram>

Deprecated as of 11/2013, and replaced by Translate.InitiationStatus.v2.

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java ('k') | no next file » | no next file with comments »