Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java

Issue 2897233002: Adds translate infobar impression in the old Translate UI on Android (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
index 5e01bbf14e6d1e18130e03583c21e7f144714425..52a8bd926e86f84b52f3a1cc769737ad59f40fc8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java
@@ -14,6 +14,7 @@ import android.text.style.ClickableSpan;
import android.view.View;
import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
import org.chromium.ui.base.DeviceFormFactor;
@@ -42,6 +43,8 @@ public class TranslateInfoBar extends InfoBar implements SubPanelListener {
private TranslateSubPanel mSubPanel;
private final boolean mShouldShowNeverBar;
+ private static final String INFOBAR_IMPRESSION_HISTOGRAM = "Translate.InfobarShown";
+
@CalledByNative
private static InfoBar show(int translateBarType, String sourceLanguageCode,
String targetLanguageCode, boolean alwaysTranslate, boolean showNeverInfobar,
@@ -173,6 +176,16 @@ public class TranslateInfoBar extends InfoBar implements SubPanelListener {
@Override
public void createContent(InfoBarLayout layout) {
+ // Log infobar impression only when the infobar shown is either in step: before translate
+ // or in step: translating and always enabled is true. This is to remove duplicate
+ // impressions.
+ int infoBarType = getInfoBarType();
+ if (infoBarType == BEFORE_TRANSLATE_INFOBAR
+ || (mOptions.alwaysTranslateLanguageState()
+ && infoBarType == TRANSLATING_INFOBAR)) {
+ RecordHistogram.recordBooleanHistogram(INFOBAR_IMPRESSION_HISTOGRAM, true);
+ }
+
if (mOptionsPanelViewType == NO_PANEL) {
mSubPanel = null;
} else {
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698