Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 2897173007: Revert of (reland) Check missing headers in the build on CQ (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of (reland) Check missing headers in the build on CQ (patchset #3 id:40001 of https://codereview.chromium.org/2903733004/ ) Reason for revert: Hit assertion in bots. crbug.com/725877 Original issue's description: > (reland) Check missing headers in the build on CQ > > This script is run on the following bots on CQ: > - linux_chromium_dbg_ng > - linux_chromium_rel_ng > > Note that this script can only be added to bots that have "all" > in "additional_compile_targets". > > BUG=661774, 725877 > > Review-Url: https://codereview.chromium.org/2903733004 > Cr-Commit-Position: refs/heads/master@{#474570} > Committed: https://chromium.googlesource.com/chromium/src/+/2f5a1ee159209aace78614d6012c361de5c3d2c3 TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661774, 725877 Review-Url: https://codereview.chromium.org/2897173007 Cr-Commit-Position: refs/heads/master@{#474691} Committed: https://chromium.googlesource.com/chromium/src/+/f9662f54a78b4eaaa0126c9726d2b67328488bef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -447 lines) Patch
M build/check_gn_headers.py View 1 chunk +1 line, -2 lines 0 comments Download
D build/check_gn_headers_whitelist.txt View 1 chunk +0 lines, -387 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -12 lines 0 comments Download
D testing/scripts/check_gn_headers.py View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
wychen
Created Revert of (reland) Check missing headers in the build on CQ
3 years, 7 months ago (2017-05-25 17:42:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897173007/1
3 years, 7 months ago (2017-05-25 17:42:39 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 17:43:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9662f54a78b4eaaa0126c9726d2...

Powered by Google App Engine
This is Rietveld 408576698