build/check_gn_headers.py - Issue 2897173007: Revert of (reland) Check missing headers in the build on CQ - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(926)

My Issues | Starred Open | Closed | All

Unified Diff: build/check_gn_headers.py

Issue 2897173007: Revert of (reland) Check missing headers in the build on CQ (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | build/check_gn_headers_whitelist.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/check_gn_headers.py

diff --git a/build/check_gn_headers.py b/build/check_gn_headers.py

index 732f6038db40b472d1c6ef9eb2d01c9062dfb92c..0850196e31b1594e8923e263ae71468794bcba0b 100755

--- a/build/check_gn_headers.py

+++ b/build/check_gn_headers.py

@@ -163,14 +163,13 @@

if args.whitelist:

whitelist = ParseWhiteList(open(args.whitelist).read())

missing -= whitelist

- nonexisting -= whitelist

missing = sorted(missing)

nonexisting = sorted(nonexisting)

if args.json:

with open(args.json, 'w') as f:

- json.dump(sorted(missing + nonexisting), f)

+ json.dump(missing, f)

if len(missing) == 0 and len(nonexisting) == 0:

return 0

« no previous file with comments | « no previous file | build/check_gn_headers_whitelist.txt » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698