Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2896893002: Minor revisions to incognito hit report code (Closed)

Created:
3 years, 7 months ago by mortonm
Modified:
3 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Addressing comments on the CL that previously landed regarding not sending hit reports when the user is in incognito mode. This is a follow up of https://codereview.chromium.org/2886043002. BUG=689149 Review-Url: https://codereview.chromium.org/2896893002 Cr-Commit-Position: refs/heads/master@{#473623} Committed: https://chromium.googlesource.com/chromium/src/+/0e97150a20f315b0d7120da514a126fb5f2ccb41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M components/safe_browsing/base_ui_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/safe_browsing/base_ui_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
mortonm
3 years, 7 months ago (2017-05-22 17:06:56 UTC) #3
vakh (use Gerrit instead)
lgtm In the description, please add that this is a follow-up of https://codereview.chromium.org/2886043002
3 years, 7 months ago (2017-05-22 17:50:49 UTC) #6
Jialiu Lin
LGTM. Thanks for addressing these!
3 years, 7 months ago (2017-05-22 17:53:00 UTC) #9
mortonm
On 2017/05/22 17:50:49, vakh (Varun Khaneja) wrote: > lgtm > > In the description, please ...
3 years, 7 months ago (2017-05-22 17:55:30 UTC) #11
mortonm
Also removed Varun's name from the description.
3 years, 7 months ago (2017-05-22 18:00:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896893002/1
3 years, 7 months ago (2017-05-22 18:02:43 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 18:10:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e97150a20f315b0d7120da514a1...

Powered by Google App Engine
This is Rietveld 408576698