Minor revisions to incognito hit report code

chrome/browser/safe_browsing/ui_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/ui_manager.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 85 matching lines @@
 
   for (Observer& observer : observer_list_)
     observer.OnSafeBrowsingHit(resource);
 }
 
 void SafeBrowsingUIManager::ShowBlockingPageForResource(
     const UnsafeResource& resource) {
   SafeBrowsingBlockingPage::ShowBlockingPage(this, resource);
 }
 
-// Static
-bool SafeBrowsingUIManager::ShouldSendHitReport(const HitReport& hit_report,
-                                                WebContents* web_contents) {
-  if (hit_report.extended_reporting_level != SBER_LEVEL_OFF &&
-      !web_contents->GetBrowserContext()->IsOffTheRecord()) {
-    return true;
-  }
-  return false;
+// static
+bool SafeBrowsingUIManager::ShouldSendHitReport(
+    const HitReport& hit_report,
+    const WebContents* web_contents) {
+  return hit_report.extended_reporting_level != SBER_LEVEL_OFF &&
+         !web_contents->GetBrowserContext()->IsOffTheRecord();
 }
 
-// A safebrowsing hit is sent after a blocking page for malware/phishing
+// A SafeBrowsing hit is sent after a blocking page for malware/phishing
 // or after the warning dialog for download urls, only for
 // extended-reporting users.
 void SafeBrowsingUIManager::MaybeReportSafeBrowsingHit(
     const HitReport& hit_report,
-    WebContents* web_contents) {
+    const WebContents* web_contents) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   // Send report if user opted-in to extended reporting and is not in
   //  incognito mode.
   if (ShouldSendHitReport(hit_report, web_contents)) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::BindOnce(&SafeBrowsingUIManager::ReportSafeBrowsingHitOnIOThread,
                        this, hit_report));
   }
@@ skipping 86 matching lines @@
   }
 }
 
 // Static.
 GURL SafeBrowsingUIManager::GetMainFrameWhitelistUrlForResourceForTesting(
     const security_interstitials::UnsafeResource& resource) {
   return GetMainFrameWhitelistUrlForResource(resource);
 }
 
 }  // namespace safe_browsing