Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3185)

Unified Diff: chrome/browser/safe_browsing/ui_manager.h

Issue 2896893002: Minor revisions to incognito hit report code (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager.h
diff --git a/chrome/browser/safe_browsing/ui_manager.h b/chrome/browser/safe_browsing/ui_manager.h
index fd21294752bb56e10999d07bd04252b37bb05a8b..9a86f71bfc55430eaddc68ef5c93a04ef713528c 100644
--- a/chrome/browser/safe_browsing/ui_manager.h
+++ b/chrome/browser/safe_browsing/ui_manager.h
@@ -67,11 +67,12 @@ class SafeBrowsingUIManager : public BaseUIManager {
// protocol buffer, so the service can send it over.
void SendSerializedThreatDetails(const std::string& serialized) override;
- // Report hits to the unsafe contents (malware, phishing, unsafe download URL)
- // to the server. Can only be called on UI thread. If |post_data| is
- // non-empty, the request will be sent as a POST instead of a GET.
- void MaybeReportSafeBrowsingHit(const safe_browsing::HitReport& hit_report,
- content::WebContents* web_contents) override;
+ // Report hits to unsafe contents (malware, phishing, unsafe download URL)
+ // to the server. Can only be called on UI thread. The hit report will
+ // only be sent if the user has enabled SBER and is not in incognito mode.
+ void MaybeReportSafeBrowsingHit(
+ const safe_browsing::HitReport& hit_report,
+ const content::WebContents* web_contents) override;
// Report permission action to SafeBrowsing servers. Can only be called on UI
// thread.
@@ -110,7 +111,7 @@ class SafeBrowsingUIManager : public BaseUIManager {
// Helper method to ensure hit reports are only sent when the user has
// opted in to extended reporting and is not currently in incognito mode.
static bool ShouldSendHitReport(const HitReport& hit_report,
- content::WebContents* web_contents);
+ const content::WebContents* web_contents);
private:
friend class SafeBrowsingUIManagerTest;
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc ('k') | chrome/browser/safe_browsing/ui_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698