Added web::NavigationContext::GetPageTransition.

Added web::NavigationContext::GetPageTransition.

This API will allow to use DidStartNavigation callback instead of
deprecated -[CRWWebDelegate webWillReload].
DidStartNavigation will check if NavigationContext::GetPageTransition
returns reload transition to act on reload navigation.

BUG=674991
Review-Url: https://codereview.chromium.org/2896623003
Cr-Commit-Position: refs/heads/master@{#473927}
Committed: https://chromium.googlesource.com/chromium/src/+/824fafed7f2df416a77d464dea6dff39bcb73407

[Eugene But (OOO till 7-30), 2017-05-19 23:22:41]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:23:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:34:47]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2017-05-22 14:44:39]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 14:45:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 14:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 14:58:48]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-22 18:48:08]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:49:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 19:03:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 19:03:42]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-22 20:48:08]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[kkhorimoto, 2017-05-22 21:13:56]

https://codereview.chromium.org/2896623003/diff/60001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2896623003/diff/60001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:1876: }
This change seems to be unrelated to the page transition stuff happening
elsewhere in this CL.  Do you think we should move it to a separate CL in case
one needs to be reverted?  Is there a specific reason you're including it here?

Also, this is a subtle change in functionality.  IsCreatedFromHashChange() is
only used to calculate whether a history navigation occurs within the same
document.  Loads created through this selector will create a new request, which
will load a new document, meaning that technically this new NavigationItem will
not be a same document navigation.  I believe that this will behave correctly
for history traversals, as pages whose URLs differ only in the fragment should
have the same document.

[Eugene But (OOO till 7-30), 2017-05-22 22:04:28]

https://codereview.chromium.org/2896623003/diff/60001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2896623003/diff/60001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:1876: }
On 2017/05/22 21:13:56, kkhorimoto_ wrote:
> This change seems to be unrelated to the page transition stuff happening
> elsewhere in this CL.  Do you think we should move it to a separate CL in case
> one needs to be reverted?  Is there a specific reason you're including it
here?
> 
> Also, this is a subtle change in functionality.  IsCreatedFromHashChange() is
> only used to calculate whether a history navigation occurs within the same
> document.  Loads created through this selector will create a new request,
which
> will load a new document, meaning that technically this new NavigationItem
will
> not be a same document navigation.  I believe that this will behave correctly
> for history traversals, as pages whose URLs differ only in the fragment should
> have the same document.  
This was needed to make sure that hash change navigation is always marked as
IsCreatedFromHashChange w/o relying to timing from window.hashchange. Otherwise
same document navigations (like going back) will not always report correct page
transition causing tests to be flaky. 

I agree that the change should be in a separate CL:
https://codereview.chromium.org/2898633003

[kkhorimoto, 2017-05-22 22:08:47]

lgtm after code from https://codereview.chromium.org/2898633003 has been
removed.

[Eugene But (OOO till 7-30), 2017-05-22 22:34:41]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:35:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:11:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:11:47]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-23 16:00:05]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-05-23 16:00:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2896623003/#ps100001
(title: "Rebased")

[commit-bot: I haz the power, 2017-05-23 16:00:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 16:18:50]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495555205324750,
"parent_rev": "d2eb8579c1d9977bb51c2041eecb431a0b5fabdc", "commit_rev":
"824fafed7f2df416a77d464dea6dff39bcb73407"}

[commit-bot: I haz the power, 2017-05-23 16:19:01]

Description was changed from

==========
Added web::NavigationContext::GetPageTransition.

This API will allow to use DidStartNavigation callback instead of
deprecated -[CRWWebDelegate webWillReload].
DidStartNavigation will check if NavigationContext::GetPageTransition
returns reload transition to act on reload navigation.

BUG=674991
==========

to

==========
Added web::NavigationContext::GetPageTransition.

This API will allow to use DidStartNavigation callback instead of
deprecated -[CRWWebDelegate webWillReload].
DidStartNavigation will check if NavigationContext::GetPageTransition
returns reload transition to act on reload navigation.

BUG=674991

Review-Url: https://codereview.chromium.org/2896623003
Cr-Commit-Position: refs/heads/master@{#473927}
Committed:
https://chromium.googlesource.com/chromium/src/+/824fafed7f2df416a77d464dea6d...
==========

[commit-bot: I haz the power, 2017-05-23 16:19:02]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/824fafed7f2df416a77d464dea6d...