Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2898633003: Mark pending item as created from hash change if necessary. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark pending item as created from hash change if necessary. This is needed because window.hashchange message may not arrive on time and navigation will not be marked as "IsCreatedFromHashChange". This will result in going through "loadURL" flow for the same document navigaitons, which is not correct. BUG=None Review-Url: https://codereview.chromium.org/2898633003 Cr-Commit-Position: refs/heads/master@{#473729} Committed: https://chromium.googlesource.com/chromium/src/+/d87e0e18ed897d6d7ebaefee1f6520a5402bcaea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-22 22:07:40 UTC) #4
Eugene But (OOO till 7-30)
Thanks for a quick review!
3 years, 7 months ago (2017-05-22 22:29:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898633003/1
3 years, 7 months ago (2017-05-22 22:43:02 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 22:49:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d87e0e18ed897d6d7ebaefee1f65...

Powered by Google App Engine
This is Rietveld 408576698