Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: ios/web/web_state/web_state_observer_bridge_unittest.mm

Issue 2896623003: Added web::NavigationContext::GetPageTransition. (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/web_state_impl_unittest.mm ('k') | ios/web/webui/crw_web_ui_manager_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_state_observer_bridge_unittest.mm
diff --git a/ios/web/web_state/web_state_observer_bridge_unittest.mm b/ios/web/web_state/web_state_observer_bridge_unittest.mm
index 38daf32bd8231b2dd2888506921ab56b345fedf7..9b19baa05373052244be40b2cffbd0c56a0f33d0 100644
--- a/ios/web/web_state/web_state_observer_bridge_unittest.mm
+++ b/ios/web/web_state/web_state_observer_bridge_unittest.mm
@@ -44,8 +44,9 @@ TEST_F(WebStateObserverBridgeTest, DidStartNavigation) {
GURL url("https://chromium.test/");
std::unique_ptr<web::NavigationContext> context =
- web::NavigationContextImpl::CreateNavigationContext(&test_web_state_,
- url);
+ web::NavigationContextImpl::CreateNavigationContext(
+ &test_web_state_, url,
+ ui::PageTransition::PAGE_TRANSITION_FORWARD_BACK);
bridge_->DidStartNavigation(context.get());
ASSERT_TRUE([observer_ didStartNavigationInfo]);
@@ -57,6 +58,9 @@ TEST_F(WebStateObserverBridgeTest, DidStartNavigation) {
EXPECT_EQ(context->IsSameDocument(), actual_context->IsSameDocument());
EXPECT_EQ(context->GetError(), actual_context->GetError());
EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());
+ EXPECT_TRUE(PageTransitionTypeIncludingQualifiersIs(
+ ui::PageTransition::PAGE_TRANSITION_FORWARD_BACK,
+ actual_context->GetPageTransition()));
EXPECT_EQ(context->GetResponseHeaders(),
actual_context->GetResponseHeaders());
}
@@ -67,8 +71,9 @@ TEST_F(WebStateObserverBridgeTest, DidFinishNavigation) {
GURL url("https://chromium.test/");
std::unique_ptr<web::NavigationContext> context =
- web::NavigationContextImpl::CreateNavigationContext(&test_web_state_,
- url);
+ web::NavigationContextImpl::CreateNavigationContext(
+ &test_web_state_, url,
+ ui::PageTransition::PAGE_TRANSITION_FROM_ADDRESS_BAR);
bridge_->DidFinishNavigation(context.get());
ASSERT_TRUE([observer_ didFinishNavigationInfo]);
@@ -80,6 +85,9 @@ TEST_F(WebStateObserverBridgeTest, DidFinishNavigation) {
EXPECT_EQ(context->IsSameDocument(), actual_context->IsSameDocument());
EXPECT_EQ(context->GetError(), actual_context->GetError());
EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());
+ EXPECT_TRUE(PageTransitionTypeIncludingQualifiersIs(
+ ui::PageTransition::PAGE_TRANSITION_FROM_ADDRESS_BAR,
+ actual_context->GetPageTransition()));
EXPECT_EQ(context->GetResponseHeaders(),
actual_context->GetResponseHeaders());
}
« no previous file with comments | « ios/web/web_state/web_state_impl_unittest.mm ('k') | ios/web/webui/crw_web_ui_manager_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698