Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2896363003: Ensure visual overflow from style recalc gets propagated (Closed)

Created:
3 years, 7 months ago by rhogan
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure visual overflow from style recalc gets propagated When recalculating overflow due to style change, the overflow we calculate may be clipped. We still need to treat it as having changed so that we can update the ContentsVisualOverflowRect() of our container. This will allow the paint layer to clip the overflow when painting it. BUG=724453 Review-Url: https://codereview.chromium.org/2896363003 Cr-Commit-Position: refs/heads/master@{#474278} Committed: https://chromium.googlesource.com/chromium/src/+/eac1506ac1502a44f10c1af30d0c4de6d7490a6b

Patch Set 1 #

Patch Set 2 : bug 724453 #

Total comments: 9

Patch Set 3 : bug 724453 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/inline-block-overflow-repaint.html View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/inline-block-overflow-repaint-expected.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
rhogan
3 years, 7 months ago (2017-05-23 19:26:09 UTC) #9
Xianzhu
https://codereview.chromium.org/2896363003/diff/20001/third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html File third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html (right): https://codereview.chromium.org/2896363003/diff/20001/third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html#newcode1 third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html:1: <!DOCTYPE html> Please put this file under paint/invalidation directory. ...
3 years, 7 months ago (2017-05-23 20:35:42 UTC) #12
rhogan
https://codereview.chromium.org/2896363003/diff/20001/third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html File third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html (right): https://codereview.chromium.org/2896363003/diff/20001/third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html#newcode1 third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html:1: <!DOCTYPE html> On 2017/05/23 at 20:35:42, Xianzhu wrote: > ...
3 years, 7 months ago (2017-05-23 21:32:17 UTC) #15
Xianzhu
lgtm. https://codereview.chromium.org/2896363003/diff/20001/third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html File third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html (right): https://codereview.chromium.org/2896363003/diff/20001/third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html#newcode3 third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html:3: p {overflow:hidden;} On 2017/05/23 21:32:16, rhogan wrote: > ...
3 years, 7 months ago (2017-05-23 21:59:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896363003/40001
3 years, 7 months ago (2017-05-24 13:25:19 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 14:04:32 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eac1506ac1502a44f10c1af30d0c...

Powered by Google App Engine
This is Rietveld 408576698