third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html - Issue 2896363003: Ensure visual overflow from style recalc gets propagated

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint.html

Issue 2896363003: Ensure visual overflow from style recalc gets propagated (Closed)

Patch Set: bug 724453 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/paint/inline-block-overflow-repaint-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Xianzhu 2017/05/23 20:35:42 Please put this file under paint/invalidation dire Please put this file under paint/invalidation directory. rhogan 2017/05/23 21:32:16 Done. Show quoted text On 2017/05/23 at 20:35:42, Xianzhu wrote: > Please put this file under paint/invalidation directory. Done.
	2 <style>

	3 p {overflow:hidden;}
	Xianzhu 2017/05/23 20:35:42 I suggest removing the above line, because whether I suggest removing the above line, because whether the container has overflow clip doesn't affect the bug (though it hides the bug visually in some cases). Then having one test div seems enough. rhogan 2017/05/23 21:32:16 Mm, not with you here - we do need the container t Show quoted text On 2017/05/23 at 20:35:42, Xianzhu wrote: > I suggest removing the above line, because whether the container has overflow clip doesn't affect the bug (though it hides the bug visually in some cases). Then having one test div seems enough. Mm, not with you here - we do need the container to want to clip the outline don't we? Xianzhu 2017/05/23 21:59:47 I found I misunderstood the bug. I thought it were Show quoted text On 2017/05/23 21:32:16, rhogan wrote: > On 2017/05/23 at 20:35:42, Xianzhu wrote: > > I suggest removing the above line, because whether the container has overflow > clip doesn't affect the bug (though it hides the bug visually in some cases). > Then having one test div seems enough. > > Mm, not with you here - we do need the container to want to clip the outline > don't we? I found I misunderstood the bug. I thought it were about incorrect visual overflow rect, but actually it was about incorrect clip.
	4 #test1 {overflow:hidden; display: inline-block;}

	5 #test2 {overflow:hidden; display: block;}

	6 </style>

	7 <p> crbug.com/724453: There should be only an outline on the right-hand side and in the descent below the text.</p>

	8 <p><a href="" id="test1"><span>Text</span></a></p>

	9 <p> crbug.com/724453: There should be no outline below.</p>

	10 <p><a href="" id="test2"><span>Text</span></a></p>

	11 <script>

	12 document.body.offsetTop;
	Xianzhu 2017/05/23 20:35:42 Please use <script src="../../resources/run-after- Please use <script src="../../resources/run-after-layout-and-paint.js"></script> <script> runAfterLayoutAndPaint(function() { test1.style.outline = ...; ... }, true); </script> This ensures a paint before the test, so the under-invalidation would reproduce. rhogan 2017/05/23 21:32:16 Done. Show quoted text On 2017/05/23 at 20:35:42, Xianzhu wrote: > Please use > <script src="../../resources/run-after-layout-and-paint.js"></script> > <script> > runAfterLayoutAndPaint(function() { > test1.style.outline = ...; > ... > }, true); > </script> > > This ensures a paint before the test, so the under-invalidation would reproduce. Done.
	13 document.getElementById("test1").style['outline'] = 'solid black 10px';

	14 document.getElementById("test2").style['outline'] = 'solid black 10px';

	15 </script>

	16

OLD	NEW