Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2896363003: Ensure visual overflow from style recalc gets propagated (Closed)
Patch Set: bug 724453 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/inline-block-overflow-repaint-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
index 496270a86f26fc7fbbe7b88ac937066e5b3fc381..1c3490669a318f8dce1ec6e8ad7b09702b718062 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -2049,7 +2049,8 @@ bool LayoutBlock::RecalcOverflowAfterStyleChange() {
if (ChildNeedsOverflowRecalcAfterStyleChange())
children_overflow_changed = RecalcChildOverflowAfterStyleChange();
- if (!SelfNeedsOverflowRecalcAfterStyleChange() && !children_overflow_changed)
+ bool self_needs_overflow_recalc = SelfNeedsOverflowRecalcAfterStyleChange();
+ if (!self_needs_overflow_recalc && !children_overflow_changed)
return false;
ClearSelfNeedsOverflowRecalcAfterStyleChange();
@@ -2066,7 +2067,7 @@ bool LayoutBlock::RecalcOverflowAfterStyleChange() {
if (HasOverflowClip())
Layer()->GetScrollableArea()->UpdateAfterOverflowRecalc();
- return !HasOverflowClip();
+ return !HasOverflowClip() || self_needs_overflow_recalc;
}
// Called when a positioned object moves but doesn't necessarily change size.
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/inline-block-overflow-repaint-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698