Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2896313002: Reland of Separate WebView's locale paks from Chrome's locale paks (Closed)

Created:
3 years, 7 months ago by F
Modified:
3 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Separate WebView's locale paks from Chrome's locale paks (patchset #1 id:1 of https://codereview.chromium.org/2894763002/ ) Reason for reland: Bot failure no longer reproducible locally TBR=agrieve@chromium.org,michaelbai@chromium.org,torne@chromium.org,thakis@chromium.org,estevenson@chromium.org BUG=687797 Review-Url: https://codereview.chromium.org/2896313002 Cr-Commit-Position: refs/heads/master@{#474023} Committed: https://chromium.googlesource.com/chromium/src/+/14032b2d2be329df3b8115b821a30518941a6226

Patch Set 1 : original patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -41 lines) Patch
M android_webview/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/BUILD.gn View 5 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_paks.gni View 3 chunks +25 lines, -23 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ResourceBundle.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
F
Created Reland of Separate WebView's locale paks from Chrome's locale paks
3 years, 7 months ago (2017-05-23 17:45:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896313002/1
3 years, 7 months ago (2017-05-23 19:57:43 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:13:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14032b2d2be329df3b8115b821a3...

Powered by Google App Engine
This is Rietveld 408576698