Separate WebView's locale paks from Chrome's locale paks

Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks
from Chrome's locale paks, and compresses locale paks for all flavors
of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed,
while their contemporary WebView is shipped as a standalone APK and has
its own locale paks stored uncompressed. For Monochrome, WebView and
Chrome share uncompressed locale paks. As a result, Monochrome locale
paks take up lots of disk space unnecessarily.

This CL changes WebView locale pak location for all WebViews, and
compresses Chrome's locale paks in Monochrome. As a result, Monochrome
now contains uncompressed WebView locale paks and compressed Chrome
locale paks. Other resources are not affected. This greatly reduces
locale paks' footprints on disk. Monochrome.apk shrinks by 2.6MB.

A side effect for this CL is that Monochrome no longer supports several
locales that have been unsupported by Chrome and Chrome modern but
supported by WebViews.

See crbug.com/687797 for more details.

BUG=687797
Review-Url: https://codereview.chromium.org/2890813002
Cr-Commit-Position: refs/heads/master@{#472801}
Committed: https://chromium.googlesource.com/chromium/src/+/b19aa78ac188365efe6b54c3889d67e9225b10d2

[F, 2017-05-17 16:51:59]

Patchset #1 (id:1) has been deleted

[F, 2017-05-17 18:25:52]

Description was changed from

==========
Separate WebView's locale paks from Chrome's locale paks

BUG=
==========

to

==========
Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks from
Chrome's locale paks, and compresses locale paks for all flavors of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed, while
their contemporary WebView is shipped as a standalone APK and has its own locale
paks stored uncompressed. For Monochrome, WebView and Chrome share uncompressed
locale paks. As a result, Monochrome locale paks take up lots of disk space
unnecessarily.

This CL changes WebView locale pak location for all WebViews, and compresses
Chrome's locale paks in Monochrome. As a result, Monochrome now contains
uncompressed WebView locale paks and compressed Chrome locale paks. Other
resources are not affected. This greatly reduces locale paks' footprints on
disk.

A side effect for this CL is that Monochrome no longer supports several locales
that have been unsupported by Chrome and Chrome modern but supported by
WebViews.

See crbug.com/687797 for more details.

BUG=687797
==========

[F, 2017-05-17 19:15:42]

Description was changed from

==========
Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks from
Chrome's locale paks, and compresses locale paks for all flavors of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed, while
their contemporary WebView is shipped as a standalone APK and has its own locale
paks stored uncompressed. For Monochrome, WebView and Chrome share uncompressed
locale paks. As a result, Monochrome locale paks take up lots of disk space
unnecessarily.

This CL changes WebView locale pak location for all WebViews, and compresses
Chrome's locale paks in Monochrome. As a result, Monochrome now contains
uncompressed WebView locale paks and compressed Chrome locale paks. Other
resources are not affected. This greatly reduces locale paks' footprints on
disk.

A side effect for this CL is that Monochrome no longer supports several locales
that have been unsupported by Chrome and Chrome modern but supported by
WebViews.

See crbug.com/687797 for more details.

BUG=687797
==========

to

==========
Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks
from Chrome's locale paks, and compresses locale paks for all flavors
of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed,
while their contemporary WebView is shipped as a standalone APK and has
its own locale paks stored uncompressed. For Monochrome, WebView and
Chrome share uncompressed locale paks. As a result, Monochrome locale
paks take up lots of disk space unnecessarily.

This CL changes WebView locale pak location for all WebViews, and
compresses Chrome's locale paks in Monochrome. As a result, Monochrome
now contains uncompressed WebView locale paks and compressed Chrome
locale paks. Other resources are not affected. This greatly reduces
locale paks' footprints on disk.

A side effect for this CL is that Monochrome no longer supports several
locales that have been unsupported by Chrome and Chrome modern but
supported by WebViews.

See crbug.com/687797 for more details.

BUG=687797
==========

[F, 2017-05-17 19:15:46]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 19:17:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2017-05-17 19:19:15]

zpeng@chromium.org changed reviewers:
+ agrieve@chromium.org

[F, 2017-05-17 19:19:16]

Hi Andrew, PTAL. Thanks!

[F, 2017-05-17 19:21:57]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 19:23:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2017-05-17 19:29:44]

agrieve@chromium.org changed reviewers:
+ michaelbai@chromium.org

[agrieve, 2017-05-17 19:29:45]

lgtm
Can you also include the in the commit description the overall size savings
(delta in MonochromePublic.apk size)

https://codereview.chromium.org/2890813002/diff/40001/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2890813002/diff/40001/android_webview/BUILD.g...
android_webview/BUILD.gn:119: renaming_destinations += [ "stored/$_locale.pak" ]
It's a bit odd that our other non-compressed .pak files aren't in this
subdirectory. How about calling it "stored-locales"

https://codereview.chromium.org/2890813002/diff/40001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/2890813002/diff/40001/chrome/android/BUILD.gn...
chrome/android/BUILD.gn:708: # This target explicitly includes locale paks.
nit: can you add "via deps" (took me a minute to figure this out :P)

[F, 2017-05-17 19:45:22]

Thanks Andrew! PTAL

Hi Michael, PTAL. Thanks!

https://codereview.chromium.org/2890813002/diff/40001/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2890813002/diff/40001/android_webview/BUILD.g...
android_webview/BUILD.gn:119: renaming_destinations += [ "stored/$_locale.pak" ]
On 2017/05/17 19:29:44, agrieve wrote:
> It's a bit odd that our other non-compressed .pak files aren't in this
> subdirectory. How about calling it "stored-locales"

Done.

https://codereview.chromium.org/2890813002/diff/40001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/2890813002/diff/40001/chrome/android/BUILD.gn...
chrome/android/BUILD.gn:708: # This target explicitly includes locale paks.
On 2017/05/17 19:29:44, agrieve wrote:
> nit: can you add "via deps" (took me a minute to figure this out :P)

Done.

[F, 2017-05-17 19:45:55]

Description was changed from

==========
Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks
from Chrome's locale paks, and compresses locale paks for all flavors
of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed,
while their contemporary WebView is shipped as a standalone APK and has
its own locale paks stored uncompressed. For Monochrome, WebView and
Chrome share uncompressed locale paks. As a result, Monochrome locale
paks take up lots of disk space unnecessarily.

This CL changes WebView locale pak location for all WebViews, and
compresses Chrome's locale paks in Monochrome. As a result, Monochrome
now contains uncompressed WebView locale paks and compressed Chrome
locale paks. Other resources are not affected. This greatly reduces
locale paks' footprints on disk.

A side effect for this CL is that Monochrome no longer supports several
locales that have been unsupported by Chrome and Chrome modern but
supported by WebViews.

See crbug.com/687797 for more details.

BUG=687797
==========

to

==========
Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks
from Chrome's locale paks, and compresses locale paks for all flavors
of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed,
while their contemporary WebView is shipped as a standalone APK and has
its own locale paks stored uncompressed. For Monochrome, WebView and
Chrome share uncompressed locale paks. As a result, Monochrome locale
paks take up lots of disk space unnecessarily.

This CL changes WebView locale pak location for all WebViews, and
compresses Chrome's locale paks in Monochrome. As a result, Monochrome
now contains uncompressed WebView locale paks and compressed Chrome
locale paks. Other resources are not affected. This greatly reduces
locale paks' footprints on disk. Monochrome.apk shrinks by 2.6MB.

A side effect for this CL is that Monochrome no longer supports several
locales that have been unsupported by Chrome and Chrome modern but
supported by WebViews.

See crbug.com/687797 for more details.

BUG=687797
==========

[F, 2017-05-17 20:36:38]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:38:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Torne, 2017-05-17 20:48:52]

torne@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2017-05-17 20:48:52]

Am I correct in interpreting the effects of this CL as:

1) Standalone WebView APK's locale paks don't change, but are moved to a new
directory in the APK.

2) Monochrome now has two of each locale pak, one in the new directory that's
small, uncompressed and the same as the corresponding WebView locale pak, and
one in the "old" location that's large, compressed, and has slightly fewer
strings than it used to (no webview-specific stuff)?

3) Strings used by both webview and chrome are duplicated across both paks in
the monochrome APK but we don't care because there are very few of them and the
saving from the compression is much larger.

If that's correct, that all sounds good :)

[michaelbai, 2017-05-17 20:53:19]

https://codereview.chromium.org/2890813002/diff/60001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (left):

https://codereview.chromium.org/2890813002/diff/60001/chrome/android/BUILD.gn...
chrome/android/BUILD.gn:605: "//v8:v8_external_startup_data_assets",
what's this change for?

[F, 2017-05-17 21:02:56]

Thanks Andrew, Michael, and Richard! PTAL

Replying to torne@:
All three points are correct :)

https://codereview.chromium.org/2890813002/diff/60001/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (left):

https://codereview.chromium.org/2890813002/diff/60001/chrome/android/BUILD.gn...
chrome/android/BUILD.gn:605: "//v8:v8_external_startup_data_assets",
On 2017/05/17 20:53:18, michaelbai wrote:
> what's this change for?

This change is a passing-by code clean up, because chrome_public_non_pak_assets
already takes care of these deps and these deps are duplicates and cause
confusion for readers.

[michaelbai, 2017-05-17 21:06:19]

lgtm

Thanks

[Torne, 2017-05-17 21:09:54]

LGTM also for the record; this is a pretty great saving!

[F, 2017-05-17 21:26:10]

zpeng@chromium.org changed reviewers:
+ thakis@chromium.org

[F, 2017-05-17 21:26:11]

Hi Nico, PTAL. Thanks!

[Nico, 2017-05-17 21:42:15]

stampy lgtm

Torne, it'd be cool if you could reply on the bug that your concerns on the bug
have been addressed.

[Torne, 2017-05-17 22:43:53]

On 2017/05/17 21:42:15, Nico wrote:
> stampy lgtm
> 
> Torne, it'd be cool if you could reply on the bug that your concerns on the
bug
> have been addressed.

Added a comment there explaining that the final design is to split the locale
paks up, not have webview rely on chrome extracting them, and therefore I have
no further concerns.

[commit-bot: I haz the power, 2017-05-17 22:50:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 22:50:13]

Dry run: This issue passed the CQ dry run.

[F, 2017-05-18 14:32:36]

The CQ bit was checked by zpeng@chromium.org

[F, 2017-05-18 14:32:36]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2890813002/#ps60001
(title: "renaming "stored"")

[commit-bot: I haz the power, 2017-05-18 14:33:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 14:38:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495117956191030,
"parent_rev": "65da2c729b4aaa8a42a03951791b28c25786c4aa", "commit_rev":
"b19aa78ac188365efe6b54c3889d67e9225b10d2"}

[commit-bot: I haz the power, 2017-05-18 14:38:41]

Description was changed from

==========
Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks
from Chrome's locale paks, and compresses locale paks for all flavors
of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed,
while their contemporary WebView is shipped as a standalone APK and has
its own locale paks stored uncompressed. For Monochrome, WebView and
Chrome share uncompressed locale paks. As a result, Monochrome locale
paks take up lots of disk space unnecessarily.

This CL changes WebView locale pak location for all WebViews, and
compresses Chrome's locale paks in Monochrome. As a result, Monochrome
now contains uncompressed WebView locale paks and compressed Chrome
locale paks. Other resources are not affected. This greatly reduces
locale paks' footprints on disk. Monochrome.apk shrinks by 2.6MB.

A side effect for this CL is that Monochrome no longer supports several
locales that have been unsupported by Chrome and Chrome modern but
supported by WebViews.

See crbug.com/687797 for more details.

BUG=687797
==========

to

==========
Separate WebView's locale paks from Chrome's locale paks

In order to reduce APK size, this CL separates WebView's locale paks
from Chrome's locale paks, and compresses locale paks for all flavors
of Chrome.

Previously, Chrome and Chrome modern have their locale paks compressed,
while their contemporary WebView is shipped as a standalone APK and has
its own locale paks stored uncompressed. For Monochrome, WebView and
Chrome share uncompressed locale paks. As a result, Monochrome locale
paks take up lots of disk space unnecessarily.

This CL changes WebView locale pak location for all WebViews, and
compresses Chrome's locale paks in Monochrome. As a result, Monochrome
now contains uncompressed WebView locale paks and compressed Chrome
locale paks. Other resources are not affected. This greatly reduces
locale paks' footprints on disk. Monochrome.apk shrinks by 2.6MB.

A side effect for this CL is that Monochrome no longer supports several
locales that have been unsupported by Chrome and Chrome modern but
supported by WebViews.

See crbug.com/687797 for more details.

BUG=687797

Review-Url: https://codereview.chromium.org/2890813002
Cr-Commit-Position: refs/heads/master@{#472801}
Committed:
https://chromium.googlesource.com/chromium/src/+/b19aa78ac188365efe6b54c3889d...
==========

[commit-bot: I haz the power, 2017-05-18 14:38:42]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b19aa78ac188365efe6b54c3889d...

[estevenson, 2017-05-19 00:15:49]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2894763002/ by estevenson@chromium.org.

The reason for reverting is: Broke downstream bot:
https://bugs.chromium.org/p/chromium/issues/detail?id=724277.

[F, 2017-05-19 00:24:49]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2884343005/ by zpeng@chromium.org.

The reason for reverting is: creates different paks for 32bit & 64bit: see
crbug.com/724277.