Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Issue 2894763002: Revert of Separate WebView's locale paks from Chrome's locale paks (Closed)

Created:
3 years, 7 months ago by estevenson
Modified:
3 years, 7 months ago
Reviewers:
michaelbai, F, Nico, agrieve, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Separate WebView's locale paks from Chrome's locale paks (patchset #3 id:60001 of https://codereview.chromium.org/2890813002/ ) Reason for revert: Broke downstream bot: https://bugs.chromium.org/p/chromium/issues/detail?id=724277 Original issue's description: > Separate WebView's locale paks from Chrome's locale paks > > In order to reduce APK size, this CL separates WebView's locale paks > from Chrome's locale paks, and compresses locale paks for all flavors > of Chrome. > > Previously, Chrome and Chrome modern have their locale paks compressed, > while their contemporary WebView is shipped as a standalone APK and has > its own locale paks stored uncompressed. For Monochrome, WebView and > Chrome share uncompressed locale paks. As a result, Monochrome locale > paks take up lots of disk space unnecessarily. > > This CL changes WebView locale pak location for all WebViews, and > compresses Chrome's locale paks in Monochrome. As a result, Monochrome > now contains uncompressed WebView locale paks and compressed Chrome > locale paks. Other resources are not affected. This greatly reduces > locale paks' footprints on disk. Monochrome.apk shrinks by 2.6MB. > > A side effect for this CL is that Monochrome no longer supports several > locales that have been unsupported by Chrome and Chrome modern but > supported by WebViews. > > See crbug.com/687797 for more details. > > BUG=687797 > > Review-Url: https://codereview.chromium.org/2890813002 > Cr-Commit-Position: refs/heads/master@{#472801} > Committed: https://chromium.googlesource.com/chromium/src/+/b19aa78ac188365efe6b54c3889d67e9225b10d2 TBR=agrieve@chromium.org,michaelbai@chromium.org,torne@chromium.org,thakis@chromium.org,zpeng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687797 Review-Url: https://codereview.chromium.org/2894763002 Cr-Commit-Position: refs/heads/master@{#472988} Committed: https://chromium.googlesource.com/chromium/src/+/1df3575f49c762037f3c3af6451a4b9e0e79ac88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -37 lines) Patch
M android_webview/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/android/BUILD.gn View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_paks.gni View 3 chunks +23 lines, -25 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ResourceBundle.java View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
estevenson
Created Revert of Separate WebView's locale paks from Chrome's locale paks
3 years, 7 months ago (2017-05-19 00:15:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2894763002/1
3 years, 7 months ago (2017-05-19 00:17:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1df3575f49c762037f3c3af6451a4b9e0e79ac88
3 years, 7 months ago (2017-05-19 00:18:39 UTC) #6
F
3 years, 7 months ago (2017-05-23 17:45:48 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2896313002/ by zpeng@chromium.org.

The reason for reverting is: Bot failure no longer reproducible locally.

Powered by Google App Engine
This is Rietveld 408576698