Reland of Reland of "ARM64: Add NEON support"

Reland of Reland of "ARM64: Add NEON support"

This reverts commit c5aad5f284b2a28b33a899cb0c5716cfbe2f6405
The CL was reverted due to missing Chromium dependencies.

This commit removes the simulator trace-based tests, and the associated header file dependencies, previously pulled in by DEPS. The NEON support now has only hand-written tests, in test-assembler-arm64.cc. The remaining tests can be added in a later patch.

BUG=chromium:718439
Original issue's description:
> Reland "ARM64: Add NEON support"
>
> This reverts commit cc047635ff54ce19b12cc91978971795f670767d.
> The CL was reverted due to a missing DEPS mirror.
>
> Original issue's description:
> > ARM64: Add NEON support
> >
> > Add assembler, disassembler and simulator support for NEON in the ARM64 backend.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2622643005
> > Cr-Commit-Position: refs/heads/master@{#44306}
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2812573003
> Cr-Commit-Position: refs/heads/master@{#44652}

Review-Url: https://codereview.chromium.org/2896303003
Cr-Commit-Position: refs/heads/master@{#45633}
Committed: https://chromium.googlesource.com/v8/v8/+/fc3f29d329c60c24cca6cddb074dd05f0ee5f0a3

[martyn.capewell, 2017-05-24 13:38:09]

Description was changed from

==========
Reland of Reland of "ARM64: Add NEON support"

This reverts commit c5aad5f284b2a28b33a899cb0c5716cfbe2f6405
The CL was reverted due to missing Chromium dependencies.

BUG=chromium:718439

Original issue's description:
> Reland "ARM64: Add NEON support"
>
> This reverts commit cc047635ff54ce19b12cc91978971795f670767d.
> The CL was reverted due to a missing DEPS mirror.
>
> Original issue's description:
> > ARM64: Add NEON support
> >
> > Add assembler, disassembler and simulator support for NEON in the ARM64
backend.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2622643005
> > Cr-Commit-Position: refs/heads/master@{#44306}
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2812573003
> Cr-Commit-Position: refs/heads/master@{#44652}
==========

to

==========
Reland of Reland of "ARM64: Add NEON support"

This reverts commit c5aad5f284b2a28b33a899cb0c5716cfbe2f6405
The CL was reverted due to missing Chromium dependencies.

BUG=chromium:718439

Original issue's description:
> Reland "ARM64: Add NEON support"
>
> This reverts commit cc047635ff54ce19b12cc91978971795f670767d.
> The CL was reverted due to a missing DEPS mirror.
>
> Original issue's description:
> > ARM64: Add NEON support
> >
> > Add assembler, disassembler and simulator support for NEON in the ARM64
backend.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2622643005
> > Cr-Commit-Position: refs/heads/master@{#44306}
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2812573003
> Cr-Commit-Position: refs/heads/master@{#44652}
==========

[martyn.capewell, 2017-05-24 13:38:10]

martyn.capewell@arm.com changed reviewers:
+ bbudge@chromium.org, bmeurer@chromium.org, machenbach@chromium.org

[bbudge, 2017-05-24 17:00:48]

lgtm

[martyn.capewell, 2017-05-26 10:12:18]

Benedikt - can I have a lgtm from an OWNER too?

[Benedikt Meurer, 2017-05-26 19:37:39]

LGTM (rubber-stamped)

[Michael Achenbach, 2017-05-29 07:05:34]

LGTM, rubber-stamped, with some questions/comments:

Since this is quite a large CL, could you add more details in the CL description
how this is done now?

Is this a somehow lighter version than the one with the external DEPS?

Was something copy/pasted from the external DEPS? Are there any licensing issues
to be considered if so?

Has the code in the several thousand added lines gone through a proper
non-rubberstamped review?

[martyn.capewell, 2017-05-30 17:08:08]

Description was changed from

==========
Reland of Reland of "ARM64: Add NEON support"

This reverts commit c5aad5f284b2a28b33a899cb0c5716cfbe2f6405
The CL was reverted due to missing Chromium dependencies.

BUG=chromium:718439

Original issue's description:
> Reland "ARM64: Add NEON support"
>
> This reverts commit cc047635ff54ce19b12cc91978971795f670767d.
> The CL was reverted due to a missing DEPS mirror.
>
> Original issue's description:
> > ARM64: Add NEON support
> >
> > Add assembler, disassembler and simulator support for NEON in the ARM64
backend.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2622643005
> > Cr-Commit-Position: refs/heads/master@{#44306}
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2812573003
> Cr-Commit-Position: refs/heads/master@{#44652}
==========

to

==========
Reland of Reland of "ARM64: Add NEON support"

This reverts commit c5aad5f284b2a28b33a899cb0c5716cfbe2f6405
The CL was reverted due to missing Chromium dependencies.

This commit removes the simulator trace-based tests, and the associated header
file dependencies, previously pulled in by DEPS. The NEON support now has only
hand-written tests, in test-assembler-arm64.cc. The remaining tests can be added
in a later patch.

BUG=chromium:718439

Original issue's description:
> Reland "ARM64: Add NEON support"
>
> This reverts commit cc047635ff54ce19b12cc91978971795f670767d.
> The CL was reverted due to a missing DEPS mirror.
>
> Original issue's description:
> > ARM64: Add NEON support
> >
> > Add assembler, disassembler and simulator support for NEON in the ARM64
backend.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2622643005
> > Cr-Commit-Position: refs/heads/master@{#44306}
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2812573003
> Cr-Commit-Position: refs/heads/master@{#44652}
==========

[martyn.capewell, 2017-05-30 17:10:05]

You're right - should've indicated in the description how I'd resolved it. Added
the info.

[Michael Achenbach, 2017-05-30 18:06:45]

thanks, lgtm

[martyn.capewell, 2017-05-31 12:37:48]

The CQ bit was checked by martyn.capewell@arm.com

[commit-bot: I haz the power, 2017-05-31 12:38:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 13:58:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496234268254010, "parent_rev":
"d8a42e4c09f60b069444b922c71c6a5c97848b30", "commit_rev":
"fc3f29d329c60c24cca6cddb074dd05f0ee5f0a3"}

[commit-bot: I haz the power, 2017-05-31 13:58:51]

Description was changed from

==========
Reland of Reland of "ARM64: Add NEON support"

This reverts commit c5aad5f284b2a28b33a899cb0c5716cfbe2f6405
The CL was reverted due to missing Chromium dependencies.

This commit removes the simulator trace-based tests, and the associated header
file dependencies, previously pulled in by DEPS. The NEON support now has only
hand-written tests, in test-assembler-arm64.cc. The remaining tests can be added
in a later patch.

BUG=chromium:718439

Original issue's description:
> Reland "ARM64: Add NEON support"
>
> This reverts commit cc047635ff54ce19b12cc91978971795f670767d.
> The CL was reverted due to a missing DEPS mirror.
>
> Original issue's description:
> > ARM64: Add NEON support
> >
> > Add assembler, disassembler and simulator support for NEON in the ARM64
backend.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2622643005
> > Cr-Commit-Position: refs/heads/master@{#44306}
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2812573003
> Cr-Commit-Position: refs/heads/master@{#44652}
==========

to

==========
Reland of Reland of "ARM64: Add NEON support"

This reverts commit c5aad5f284b2a28b33a899cb0c5716cfbe2f6405
The CL was reverted due to missing Chromium dependencies.

This commit removes the simulator trace-based tests, and the associated header
file dependencies, previously pulled in by DEPS. The NEON support now has only
hand-written tests, in test-assembler-arm64.cc. The remaining tests can be added
in a later patch.

BUG=chromium:718439

Original issue's description:
> Reland "ARM64: Add NEON support"
>
> This reverts commit cc047635ff54ce19b12cc91978971795f670767d.
> The CL was reverted due to a missing DEPS mirror.
>
> Original issue's description:
> > ARM64: Add NEON support
> >
> > Add assembler, disassembler and simulator support for NEON in the ARM64
backend.
> >
> > BUG=
> >
> > Review-Url: https://codereview.chromium.org/2622643005
> > Cr-Commit-Position: refs/heads/master@{#44306}
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2812573003
> Cr-Commit-Position: refs/heads/master@{#44652}

Review-Url: https://codereview.chromium.org/2896303003
Cr-Commit-Position: refs/heads/master@{#45633}
Committed:
https://chromium.googlesource.com/v8/v8/+/fc3f29d329c60c24cca6cddb074dd05f0ee...
==========

[commit-bot: I haz the power, 2017-05-31 13:58:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fc3f29d329c60c24cca6cddb074dd05f0ee...