Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2812573003: Reland "ARM64: Add NEON support" (Closed)

Created:
3 years, 8 months ago by martyn.capewell
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "ARM64: Add NEON support" This reverts commit cc047635ff54ce19b12cc91978971795f670767d. The CL was reverted due to a missing DEPS mirror. Original issue's description: > ARM64: Add NEON support > > Add assembler, disassembler and simulator support for NEON in the ARM64 backend. > > BUG= > > Review-Url: https://codereview.chromium.org/2622643005 > Cr-Commit-Position: refs/heads/master@{#44306} BUG= Review-Url: https://codereview.chromium.org/2812573003 Cr-Commit-Position: refs/heads/master@{#44652} Committed: https://chromium.googlesource.com/v8/v8/+/8faf3d6f25096fb68e4fed4f772bb7052192d704

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Add trace directory to gitignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30531 lines, -2914 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 2 24 chunks +1558 lines, -167 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 2 14 chunks +2104 lines, -325 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 2 15 chunks +130 lines, -59 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 7 chunks +17 lines, -20 lines 0 comments Download
M src/arm64/constants-arm64.h View 1 2 15 chunks +948 lines, -87 lines 0 comments Download
M src/arm64/decoder-arm64.h View 1 2 3 chunks +75 lines, -46 lines 0 comments Download
M src/arm64/decoder-arm64-inl.h View 1 2 4 chunks +185 lines, -19 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/disasm-arm64.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/arm64/disasm-arm64.cc View 1 2 19 chunks +2456 lines, -168 lines 0 comments Download
M src/arm64/instructions-arm64.h View 1 2 8 chunks +287 lines, -26 lines 0 comments Download
M src/arm64/instructions-arm64.cc View 1 2 5 chunks +452 lines, -30 lines 0 comments Download
M src/arm64/instrument-arm64.cc View 1 2 2 chunks +154 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 18 chunks +682 lines, -112 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 19 chunks +192 lines, -32 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 2 7 chunks +87 lines, -170 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 2 19 chunks +1554 lines, -104 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 2 34 chunks +2766 lines, -943 lines 0 comments Download
A src/arm64/simulator-logic-arm64.cc View 1 2 1 chunk +4198 lines, -0 lines 0 comments Download
M src/arm64/utils-arm64.h View 1 2 5 chunks +22 lines, -30 lines 0 comments Download
M src/arm64/utils-arm64.cc View 1 2 3 chunks +83 lines, -39 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 10 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/crankshaft/arm64/delayed-masm-arm64.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/delayed-masm-arm64-inl.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 11 chunks +16 lines, -17 lines 0 comments Download
M src/crankshaft/arm64/lithium-gap-resolver-arm64.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 2 38 chunks +4338 lines, -423 lines 0 comments Download
M test/cctest/test-disasm-arm64.cc View 1 2 13 chunks +3157 lines, -11 lines 0 comments Download
A test/cctest/test-simulator-neon-arm64.cc View 1 2 1 chunk +2562 lines, -0 lines 0 comments Download
A test/cctest/test-simulator-neon-inputs-arm64.h View 1 2 1 chunk +952 lines, -0 lines 0 comments Download
A test/cctest/test-simulator-neon-traces-arm64.h View 1 2 1 chunk +1414 lines, -0 lines 0 comments Download
M test/cctest/test-utils-arm64.h View 1 2 8 chunks +34 lines, -16 lines 0 comments Download
M test/cctest/test-utils-arm64.cc View 1 2 9 chunks +58 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
martyn.capewell
3 years, 8 months ago (2017-04-10 17:04:26 UTC) #2
Michael Achenbach
New DEPS lgtm if comment addressed. https://codereview.chromium.org/2812573003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2812573003/diff/1/DEPS#newcode40 DEPS:40: "v8/test/cctest/traces-arm64": Please add ...
3 years, 8 months ago (2017-04-11 08:20:28 UTC) #3
martyn.capewell
Benedikt, if you're happy with the rest of it, I'll try to commit again.
3 years, 8 months ago (2017-04-13 14:09:36 UTC) #4
Benedikt Meurer
I'm happy. LGTM.
3 years, 8 months ago (2017-04-13 16:45:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812573003/20001
3 years, 8 months ago (2017-04-13 16:46:55 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 17:23:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8faf3d6f25096fb68e4fed4f772bb705219...

Powered by Google App Engine
This is Rietveld 408576698